Do not fetch all organizations when UI opened #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
changed the title
bsekachev
changed the title
bsekachev
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #7004 +/- ##
===========================================
+ Coverage 82.31% 82.37% +0.05%
===========================================
Files 361 361
Lines 39168 39178 +10
Branches 3586 3585 -1
===========================================
+ Hits 32243 32271 +28
+ Misses 6925 6907 -18
|
bsekachev
force-pushed
the
bs/disable_fetch_all_orgs
branch
from
b2fd8ca
to
3abff8f
Compare
bsekachev
force-pushed
the
bs/disable_fetch_all_orgs
branch
from
b0949ac
to
984a556
Compare
bsekachev
requested review from
klakhov
and removed request for
Marishka17 and
nmanovic
klakhov
reviewed
Oct 17, 2023
Comment on lines
+116
to
+117
| } else { | ||
| dispatch(organizationActions.activateOrganizationFailed(curSlug, 'Unknown error')); |
There was a problem hiding this comment.
What kind of error can be thrown here? (which is not an Error)
There was a problem hiding this comment.
Any error from anywhere. We can't guarantee that it is only Error at all.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#unknown-on-catch-clause-bindings
Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
klakhov
approved these changes
Oct 19, 2023
Merged
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Now it takes 10+ seconds to receive extra data on app.cvat.ai
Resolved #5982
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.