Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fetch existing annotations in cvat_sdk.auto_annotation.annotate_task #7019

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Oct 17, 2023

Motivation and context

We don't need existing annotations in order to re-annotate a task, but they were being fetched anyway, because that's how the underlying TaskDataset class works.

Add an option to TaskDataset to disable annotation loading, and use it in auto_annotate to prevent those unnecessary fetches.

How has this been tested?

Unit tests.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

…e_task`

We don't need existing annotations in order to re-annotate a task, but they
were being fetched anyway, because that's how the underlying `TaskDataset`
class works.

Add an option to `TaskDataset` to disable annotation loading, and use it in
`auto_annotate` to prevent those unnecessary fetches.
@SpecLad SpecLad marked this pull request as ready for review October 18, 2023 11:17
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #7019 (347e468) into develop (e6724fa) will decrease coverage by 0.01%.
Report is 7 commits behind head on develop.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##           develop    #7019      +/-   ##
===========================================
- Coverage    82.31%   82.31%   -0.01%     
===========================================
  Files          361      361              
  Lines        39168    39173       +5     
  Branches      3586     3586              
===========================================
+ Hits         32243    32246       +3     
- Misses        6925     6927       +2     
Components Coverage Δ
cvat-ui 77.28% <ø> (ø)
cvat-server 86.94% <93.33%> (-0.01%) ⬇️

@nmanovic nmanovic merged commit 8197cd2 into cvat-ai:develop Oct 18, 2023
42 checks passed
@SpecLad SpecLad deleted the auto-annotate-no-load branch October 18, 2023 13:57
@cvat-bot cvat-bot bot mentioned this pull request Oct 23, 2023
mikhail-treskin pushed a commit to retailnext/cvat that referenced this pull request Oct 25, 2023
…e_task` (cvat-ai#7019)

We don't need existing annotations in order to re-annotate a task, but
they were being fetched anyway, because that's how the underlying
`TaskDataset` class works.

Add an option to `TaskDataset` to disable annotation loading, and use it
in `auto_annotate` to prevent those unnecessary fetches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants