SDK: determine supported server versions automatically #7026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the spirit of the `SUPPORTED_SERVER_VERSIONS` constant is to allow the same and the next minor versions as the SDK, so just derive those versions automatically instead of bumping them every minor release.
Codecov Report
@@ Coverage Diff @@
## develop #7026 +/- ##
===========================================
+ Coverage 82.31% 82.36% +0.04%
===========================================
Files 361 361
Lines 39168 39168
Branches 3586 3586
===========================================
+ Hits 32243 32259 +16
+ Misses 6925 6909 -16
|
zhiltsov-max
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
I think the spirit of the SUPPORTED_SERVER_VERSIONS constant is to allow the same and the next minor versions as the SDK
It was never supposed to be like this - the variable is literally the list of supported versions for each SDK release. But we can surely add this change to simplify maintenance of new releases, as it reflects our current strategy.
Okay, I'm going to remove this part from the commit message. |
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Oct 25, 2023
This removes what should be the last manual step that used to be involved in making a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
I think the spirit of the
SUPPORTED_SERVER_VERSIONSconstant is to allow the same and the next minor versions as the SDK, so just derive those versions automatically instead of bumping them every minor release.How has this been tested?
I examined
cvat_sdk.Client.SUPPORTED_SERVER_VERSIONSin the REPL.Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues(see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.