Handle task creation with unsupported data types from cloud storage with cache enabled #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7087 +/- ##
===========================================
+ Coverage 82.34% 82.39% +0.05%
===========================================
Files 361 362 +1
Lines 39222 39408 +186
Branches 3588 3592 +4
===========================================
+ Hits 32298 32471 +173
- Misses 6924 6937 +13
|
nmanovic
reviewed
Nov 7, 2023
| media, task_mode = _validate_data(media, manifest_files) | ||
|
|
||
| if is_data_in_cloud: | ||
| # first we need to filter files and keep only supported ones |
There was a problem hiding this comment.
Looks like the comment is wrong. You just check that a list has non-images.
nmanovic
reviewed
Nov 7, 2023
| @@ -636,17 +642,28 @@ def _create_thread( | |||
| filtered_files.append(f) | |||
| data['server_files'] = filtered_files | |||
|
|
|||
| # count and validate uploaded files | |||
| media = _count_files(data) | |||
There was a problem hiding this comment.
It is old code. But "_count_files" doesn't correspond to what the function does. It splits files by the media type. Let's keep as is for now.
nmanovic
deleted the
mk/handle_task_creation_withvideo_from_cs_and_cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This PR ignores the
use cacheoption on the server when creating tasks with cloud storage data (except images)How has this been tested?
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (see GitHub docs)- [ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.