Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of datetime.utcfromtimestamp #7102

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Nov 6, 2023

Motivation and context

It's been deprecated in 3.12, and fromtimestamp is easier to use anyway.

In addition, drop the pytz dependency, since the UTC time zone is available in the standard library.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

It's been deprecated in 3.12, and `fromtimestamp` is easier to use anyway.

In addition, drop the pytz dependency, since the UTC time zone is available
in the standard library.
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #7102 (621164c) into develop (5392763) will decrease coverage by 0.06%.
Report is 2 commits behind head on develop.
The diff coverage is 65.78%.

@@             Coverage Diff             @@
##           develop    #7102      +/-   ##
===========================================
- Coverage    82.43%   82.37%   -0.06%     
===========================================
  Files          361      362       +1     
  Lines        39310    39398      +88     
  Branches      3591     3592       +1     
===========================================
+ Hits         32405    32454      +49     
- Misses        6905     6944      +39     
Components Coverage Δ
cvat-ui 77.35% <66.66%> (-0.08%) ⬇️
cvat-server 86.95% <65.73%> (-0.07%) ⬇️

@nmanovic nmanovic merged commit 0f58426 into cvat-ai:develop Nov 7, 2023
34 checks passed
@SpecLad SpecLad deleted the rm-utcfromtimestamp branch September 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants