Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit 1 user to 1 active task at a time #7106

Merged
merged 14 commits into from
Nov 22, 2023

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Nov 7, 2023

Motivation and context

The PR contains a REST API test that checks that a single user cannot clog the import queue with his tasks.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
    - [ ] I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
    - [ ] I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Marishka17 Marishka17 changed the title [WIP][Test] Limit 1 user to 1 task at a time [Do not merge][Test] Limit 1 user to 1 task at a time Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #7106 (fbf0e59) into develop (e1d4f30) will decrease coverage by 1.13%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7106      +/-   ##
===========================================
- Coverage    82.55%   81.42%   -1.13%     
===========================================
  Files          362      364       +2     
  Lines        39264    39904     +640     
  Branches      3578     3699     +121     
===========================================
+ Hits         32413    32492      +79     
- Misses        6851     7412     +561     
Components Coverage Δ
cvat-ui 75.49% <ø> (-2.19%) ⬇️
cvat-server 86.98% <ø> (+0.01%) ⬆️

@Marishka17 Marishka17 force-pushed the mk/test_limit_one_user_to_one_task_at_a_time branch from b1ac754 to 134effe Compare November 8, 2023 09:34
@Marishka17 Marishka17 changed the title [Do not merge][Test] Limit 1 user to 1 task at a time Limit 1 user to 1 active task at a time Nov 8, 2023
.github/workflows/main.yml Outdated Show resolved Hide resolved
tests/python/README.md Outdated Show resolved Hide resolved
tests/python/README.md Outdated Show resolved Hide resolved
tests/python/rest_api/test_queues.py Show resolved Hide resolved
Marishka17 and others added 3 commits November 15, 2023 10:02
Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
@azhavoro
Copy link
Contributor

LGTM

@nmanovic nmanovic merged commit fe21844 into develop Nov 22, 2023
34 checks passed
@nmanovic nmanovic deleted the mk/test_limit_one_user_to_one_task_at_a_time branch November 22, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants