Turn on Traefik access logs #7109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
traefik-logs
branch
2 times, most recently
from
7e542b7
to
af1907b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7109 +/- ##
===========================================
- Coverage 81.42% 81.40% -0.03%
===========================================
Files 364 364
Lines 39904 39904
Branches 3699 3699
===========================================
- Hits 32491 32483 -8
- Misses 7413 7421 +8
|
azhavoro
reviewed
Nov 13, 2023
docker-compose.yml
Outdated
| @@ -224,6 +224,22 @@ services: | |||
| container_name: traefik | |||
| restart: always | |||
| command: | |||
| - '--log.format=json' | |||
There was a problem hiding this comment.
It doesn't seem to work if use with docker-compose.https.yml.
SpecLad
force-pushed
the
traefik-logs
branch
from
af1907b
to
3d840a5
Compare
This will be useful for debugging issues and gathering statistics. Use the JSON format, since that allows us to include more information than the traditional HTTP access logs. Switch the other logs to JSON as well, for ease of parsing. Add a cap on the size of the log in Docker compose, since the JSON logs are pretty bulky, and we don't want users to inadvertently run out of space.
SpecLad
force-pushed
the
traefik-logs
branch
from
3d840a5
to
e3ced1e
Compare
|
I added a log file size cap too. |
azhavoro
approved these changes
Nov 17, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
This will be useful for debugging issues and gathering statistics.
Use the JSON format, since that allows us to include more information than the traditional HTTP access logs. Switch the other logs to JSON as well, for ease of parsing.
How has this been tested?
Manual testing.
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.