Helm: keep the data PersistentVolumeClaim after uninstall #7123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Helm will delete the PVC when you uninstall your CVAT release, which makes it easy to unintentionally lose data. Add a `helm.sh/resource-policy` annotation to prevent that from happening. This makes the data PVC consistent with the other PVCs created as part of the Helm chart (ones belonging to PostgreSQL, KeyDB and Clickhouse), which are also not deleted upon uninstall, albeit for a different reason: they are created by the corresponding StatefulSets, and StatefulSets retain their volumes when they are deleted.
SpecLad
force-pushed
the
helm-keep-pvc
branch
from
f4579a7
to
8dafd55
Compare
azhavoro
approved these changes
Nov 10, 2023
Codecov Report
@@ Coverage Diff @@
## develop #7123 +/- ##
===========================================
+ Coverage 82.43% 82.58% +0.15%
===========================================
Files 361 362 +1
Lines 39310 39264 -46
Branches 3591 3578 -13
===========================================
+ Hits 32405 32426 +21
+ Misses 6905 6838 -67
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Currently, Helm will delete the PVC when you uninstall your CVAT release, which makes it easy to unintentionally lose data. Add a
helm.sh/resource-policyannotation to prevent that from happening.This makes the data PVC consistent with the other PVCs created as part of the Helm chart (ones belonging to PostgreSQL, KeyDB and Clickhouse), which are also not deleted upon uninstall, albeit for a different reason: they are created by the corresponding StatefulSets, and StatefulSets retain their volumes when they are deleted.
How has this been tested?
I installed and uninstalled the chart, and verified that the PVC stayed behind.
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.