-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client code refactoring #7208
Client code refactoring #7208
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7208 +/- ##
===========================================
+ Coverage 81.48% 81.50% +0.01%
===========================================
Files 365 365
Lines 39918 39257 -661
Branches 3703 3631 -72
===========================================
- Hits 32529 31996 -533
+ Misses 7389 7261 -128
|
cvat-data/src/ts/3rdparty_patch.diff
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we did not use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Initially we used this patch file to patch the library during build
- As I discovered, patched version was already commited long time ago and we don't use the file anymore
- Finally I do not really see a reason to patch this file, their repository is dead, we don't receive any updates. License allows us to modify it, so..
Motivation and context
{ "type": "module" }
in package.json.cvat-core
global types, nowgetCore()
returns typed objectwindow
there. I hope soon we will be able to get rid ofjsdom
dependency. Right now 3rdparty packages fromcvat-data
don't allow to do thatcvat-data
module.How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.