Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace keydb with kvrocks #7339

Merged
merged 10 commits into from
Jan 18, 2024
Merged

Replace keydb with kvrocks #7339

merged 10 commits into from
Jan 18, 2024

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Jan 10, 2024

Motivation and context

Resolved #7345

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@azhavoro azhavoro force-pushed the az/switch_to_kvrocks branch from 7944ad9 to 4d62105 Compare January 10, 2024 09:03
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #7339 (1163406) into develop (d25b863) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7339      +/-   ##
===========================================
- Coverage    83.26%   83.25%   -0.01%     
===========================================
  Files          373      373              
  Lines        39615    39615              
  Branches      3701     3701              
===========================================
- Hits         32984    32981       -3     
- Misses        6631     6634       +3     
Components Coverage Δ
cvat-ui 79.02% <ø> (-0.02%) ⬇️
cvat-server 87.12% <ø> (ø)

@azhavoro azhavoro requested a review from SpecLad January 10, 2024 13:01
helm-chart/templates/cvat_kvrocks/deployment.yml Outdated Show resolved Hide resolved
docker-compose.dev.yml Outdated Show resolved Hide resolved
helm-chart/templates/cvat_kvrocks/deployment.yml Outdated Show resolved Hide resolved
helm-chart/values.yaml Outdated Show resolved Hide resolved
helm-chart/values.yaml Outdated Show resolved Hide resolved
helm-chart/values.yaml Outdated Show resolved Hide resolved
helm-chart/values.yaml Outdated Show resolved Hide resolved
helm-chart/values.yaml Outdated Show resolved Hide resolved
@SpecLad
Copy link
Contributor

SpecLad commented Jan 11, 2024

Please add a changelog entry.

@azhavoro azhavoro requested a review from Marishka17 as a code owner January 15, 2024 10:36
@bsekachev bsekachev mentioned this pull request Jan 15, 2024
helm-chart/values.yaml Outdated Show resolved Hide resolved
cvat/settings/base.py Outdated Show resolved Hide resolved
@azhavoro azhavoro requested a review from nmanovic as a code owner January 15, 2024 14:30
@SpecLad SpecLad merged commit 7a1a4b1 into develop Jan 18, 2024
34 checks passed
@SpecLad SpecLad deleted the az/switch_to_kvrocks branch January 18, 2024 10:08
@cvat-bot cvat-bot bot mentioned this pull request Jan 18, 2024
@tisonkun
Copy link

tisonkun commented Mar 1, 2024

Glad to see CVAT choose Apache Kvrocks as the on-disk Redis solution.

Would you mind to add you in Kvrocks Users page? I prepare a PR for you to preview apache/kvrocks-website#200 but your opinion is significant and perhaps you'd propose a different brand kit.

cc @SpecLad @bsekachev

@nmanovic
Copy link
Contributor

nmanovic commented Mar 1, 2024

@tisonkun , thank you!

Please download icons from here https://www.cvat.ai/media. We would prefer to use the icon below:

Icon - 512

@tisonkun
Copy link

tisonkun commented Mar 1, 2024

Hi @nmanovic! @bsekachev suggested a different logo at apache/kvrocks-website#200 (comment). Please take a look if there is unaligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPA Helm Chart
4 participants