Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout and actions/setup-node to v4 #7442

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Feb 5, 2024

Motivation and context

v3 of these actions use Node 16, which is deprecated in GitHub Actions:

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • [ ] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad SpecLad requested a review from bsekachev February 5, 2024 14:06
@bsekachev
Copy link
Member

Shall we update other recommended packages?

  • actions/setup-node@v3
  • actions/download-artifact@v3
  • actions/upload-artifact@v3.1.1

@SpecLad SpecLad force-pushed the rd/bump-actions-checkout branch from c22a079 to a296ee7 Compare February 6, 2024 10:50
@SpecLad SpecLad changed the title Bump actions/checkout to v4 Bump actions/checkout and actions/setup-node to v4 Feb 6, 2024
@SpecLad
Copy link
Contributor Author

SpecLad commented Feb 6, 2024

I updated setup-node. As for upload-artifact and download-artifact, it seems that their new versions have substantial changes in behavior, so I'd rather leave them out for now.

@bsekachev bsekachev merged commit dc40be2 into cvat-ai:develop Feb 6, 2024
33 checks passed
SpecLad added a commit that referenced this pull request Sep 10, 2024
This is a followup to #7442. I didn't realize there were so many
outdated actions. 🙂

This should update every remaining action with a Node 12/16 dependency.
@SpecLad SpecLad deleted the rd/bump-actions-checkout branch September 10, 2024 15:53
bschultz96 pushed a commit to bschultz96/cvat that referenced this pull request Sep 12, 2024
…7459)

This is a followup to cvat-ai#7442. I didn't realize there were so many
outdated actions. 🙂

This should update every remaining action with a Node 12/16 dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants