Fixed: UI crashes when use DateTimePicker in filters #8055
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes fix an issue in the system where date filters for tasks and jobs were not working correctly. Additionally, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (2)
- changelog.d/20240619_202033_sekachev.bs_fixed_issue_8054.md (1 hunks)
- cvat-ui/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- cvat-ui/package.json
| - Filters by created date, updated date do not work on different pages (e.g. list of tasks or jobs) | ||
| (<https://github.com/cvat-ai/cvat/pull/8055>) |
There was a problem hiding this comment.
The changelog entry clearly describes the fix and correctly links to the associated pull request. Consider specifying the exact pages affected for better clarity.
- Filters by created date, updated date do not work on different pages (e.g. list of tasks or jobs)
+ Filters by created date and updated date were not functioning on specific pages such as the task list and job list.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Filters by created date, updated date do not work on different pages (e.g. list of tasks or jobs) | |
| (<https://github.com/cvat-ai/cvat/pull/8055>) | |
| - Filters by created date, updated date do not work on different pages (e.g. list of tasks or jobs) | |
| + Filters by created date and updated date were not functioning on specific pages such as the task list and job list. |
|
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
Chores
@react-awesome-query-builder/antdto version6.5.2to enhance query building capabilities in the UI.