-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: don't send the cleanup parameter on interactive detector calls #8075
Conversation
The server doesn't support it, and it wouldn't make sense anyway. Potentially it could be handled on the client side, but right now it isn't.
WalkthroughA small adjustment was made to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx (1 hunks)
Additional comments not posted (1)
cvat-ui/src/components/annotation-page/standard-workspace/controls-side-bar/tools-control.tsx (1)
1236-1236
: Approved: Removal of unsupported parameters.The exclusion of
cleanup
from the destructuredbody
object aligns with the PR objective to prevent sending unsupported parameters to the server, enhancing the robustness and correctness of the API interaction.However, ensure that the removal of
convMaskToPoly
does not affect other functionalities where this parameter might be expected.
Motivation and context
The server doesn't support it, and it wouldn't make sense anyway. Potentially it could be handled on the client side, but right now it isn't.
This should've been a part of #8074, but I didn't realize there was a similar issue with
cleanup
as withconvMaskToPoly
.How has this been tested?
Manual testing.
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
[ ] I submit my code changes under the same MIT License that covers the project.Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
cleanup
parameter was not correctly deconstructed in the annotation tools control, improving the reliability of theconvMaskToPoly
feature.