Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: The switcher to block an active tool on annotation header is not highligted properly #8081

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 25, 2024

Motivation and context

image

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Style
    • Fixed issue where the switcher to block an active tool on the annotation header was not highlighted correctly.
    • Improved hover effect styling for buttons to enhance user experience.

@bsekachev bsekachev requested a review from nmanovic as a code owner June 25, 2024 10:02
Copy link
Contributor

coderabbitai bot commented Jun 25, 2024

Walkthrough

The update addresses a styling issue in the CVAT tool's annotation header. Specifically, it ensures the active tool switcher is now highlighted correctly by introducing a new CSS rule for the .cvat-button-active class. This fix improves visual feedback for users interacting with active tools in the annotation interface.

Changes

File Path Change Summary
changelog.d/20240625_130102_boris_minor_style_fix.md Introduced a changelog entry documenting the fix for highlighting the switcher of an active tool in the CVAT tool.
cvat-ui/src/components/annotation-page/styles.scss Added a new style rule for the .cvat-button-active class to set the color to $border-color-hover, and removed a previous rule from .cvat-button-active.ant-btn.

Poem

In fields where code and styles entwine,
The buttons now with grace do shine.
New colors set and old removed,
Our tools in CVAT have improved.
A button's glow, a coder's glee,
Now, highlight tools so perfectly! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 25fc37b and 935b156.

Files selected for processing (2)
  • changelog.d/20240625_130102_boris_minor_style_fix.md (1 hunks)
  • cvat-ui/src/components/annotation-page/styles.scss (2 hunks)
Files skipped from review due to trivial changes (1)
  • changelog.d/20240625_130102_boris_minor_style_fix.md
Additional comments not posted (2)
cvat-ui/src/components/annotation-page/styles.scss (2)

41-43: Enhanced visibility for active tools.

The new styling rule for .cvat-button-active which sets the color to $border-color-hover should effectively address the issue of the switcher not being highlighted properly. This change makes the active state more visually distinct, aligning with the PR objectives to enhance UI clarity.


41-43: Streamlined CSS for consistency.

Removing the .cvat-button-active.ant-btn specific rule and consolidating the style under .cvat-button-active simplifies the CSS and reduces potential specificity conflicts. This should make future maintenance easier and ensure consistent styling across similar components.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (25fc37b) to head (935b156).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8081   +/-   ##
========================================
  Coverage    83.62%   83.62%           
========================================
  Files          383      383           
  Lines        40439    40439           
  Branches      3815     3815           
========================================
+ Hits         33817    33819    +2     
+ Misses        6622     6620    -2     
Components Coverage Δ
cvat-ui 79.60% <ø> (+<0.01%) ⬆️
cvat-server 87.30% <ø> (+<0.01%) ⬆️

@bsekachev bsekachev merged commit 18aae08 into develop Jun 25, 2024
33 checks passed
@bsekachev bsekachev deleted the bs/minor_style_fix branch June 26, 2024 06:15
@cvat-bot cvat-bot bot mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants