-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style: The switcher to block an active tool on annotation header is not highligted properly #8081
Conversation
WalkthroughThe update addresses a styling issue in the CVAT tool's annotation header. Specifically, it ensures the active tool switcher is now highlighted correctly by introducing a new CSS rule for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- changelog.d/20240625_130102_boris_minor_style_fix.md (1 hunks)
- cvat-ui/src/components/annotation-page/styles.scss (2 hunks)
Files skipped from review due to trivial changes (1)
- changelog.d/20240625_130102_boris_minor_style_fix.md
Additional comments not posted (2)
cvat-ui/src/components/annotation-page/styles.scss (2)
41-43
: Enhanced visibility for active tools.The new styling rule for
.cvat-button-active
which sets the color to$border-color-hover
should effectively address the issue of the switcher not being highlighted properly. This change makes the active state more visually distinct, aligning with the PR objectives to enhance UI clarity.
41-43
: Streamlined CSS for consistency.Removing the
.cvat-button-active.ant-btn
specific rule and consolidating the style under.cvat-button-active
simplifies the CSS and reduces potential specificity conflicts. This should make future maintenance easier and ensure consistent styling across similar components.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8081 +/- ##
========================================
Coverage 83.62% 83.62%
========================================
Files 383 383
Lines 40439 40439
Branches 3815 3815
========================================
+ Hits 33817 33819 +2
+ Misses 6622 6620 -2
|
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit