Fixed ordering of frame intersection column on Quality page
#8089
Conversation
WalkthroughA fix has been applied to the task quality page in the CVAT project, addressing the sorting functionality for the Changes
Sequence Diagram(s)No significant changes to the control flow, so sequence diagrams are not applicable. Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- changelog.d/20240626_104311_klakhov_fix_frame_intersection_ordering.md (1 hunks)
- cvat-ui/package.json (1 hunks)
- cvat-ui/src/components/analytics-page/task-quality/job-list.tsx (4 hunks)
Files skipped from review due to trivial changes (2)
- changelog.d/20240626_104311_klakhov_fix_frame_intersection_ordering.md
- cvat-ui/package.json
Additional comments not posted (4)
cvat-ui/src/components/analytics-page/task-quality/job-list.tsx (4)
9-9: Import statement updated to includeKey.This change supports the new type requirements for the
onFilterfunctions, ensuring they can accept aKeytype, which is necessary for the improvements in sorting functionality.
123-123: UpdatedonFilterfunction for "Stage" column to acceptboolean | Key.This change ensures that the function can handle the appropriate data types for filtering, aligning with the updated import and improving the sorting functionality.
135-135: UpdatedonFilterfunction for "Assignee" column to acceptboolean | Key.Aligning with the changes in the "Stage" column, this update ensures consistent and correct data type handling for filtering by assignee.
144-144: Updatedsorterfunction for "Frame intersection" column to useframeCount.This change is crucial as it addresses the main issue reported in the PR by ensuring that jobs are sorted based on their frame intersection values rather than job IDs. This modification directly impacts the functionality and correctness of the sorting on the Quality page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8089 +/- ##
===========================================
- Coverage 83.62% 83.61% -0.02%
===========================================
Files 383 383
Lines 40450 40454 +4
Branches 3820 3821 +1
===========================================
- Hits 33828 33826 -2
- Misses 6622 6628 +6
|
Motivation and context
Resolved #8022
Before:
After:
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
frame intersectioncolumn on the task quality page.New Features
Chores
cvat-uipackage version from 1.63.11 to 1.63.12.