Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show job assignee from quality reports in UI #8123

Merged
merged 18 commits into from
Jul 16, 2024

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jul 5, 2024

Depends on #8119

Motivation and context

  • Changed source for job assignees on the Quality analytics page from the current job data to the report data

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Introduced tracking and reporting of the last assignee update time.
    • Added an assignee field to Quality Reports for better user assignment management.
  • Enhancements

    • Updated Project, Task, and Job models to include an assignee_updated_date field, improving assignment tracking.
  • Bug Fixes

    • Adjusted job and task serializers to handle new assignee-related fields correctly.
  • Tests

    • Added test cases for job, project, task, and quality report creation and assignee updates.
  • Documentation

    • Updated schema to reflect new assignee_updated_date field.

@zhiltsov-max zhiltsov-max changed the title Show job assignee from quality reports in UI [Dependent] Show job assignee from quality reports in UI Jul 5, 2024
Copy link
Contributor

coderabbitai bot commented Jul 5, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes introduce a new feature to track the last update time of assignees for jobs, projects, and tasks in CVAT. Key updates include adding an assignee_updated_date field to relevant models, integrating this field into serializers, views, and API tests, and extending the QualityReport class to include an assignee. The front-end adjustments ensure that assignee information is accurately displayed and processed.

Changes

Files Change Summaries
changelog.d/... Introduced functionality for tracking the last assignee update time.
cvat-core/src/quality-report.ts Added assignee property and method to QualityReport class.
cvat-core/src/server-response-types.ts Included assignee field in SerializedQualityReportData interface.
cvat-ui/src/components/analytics-page/task-quality/job-list.tsx Adjusted functions and render methods to handle QualityReport's assignee.
cvat/apps/engine/migrations/... Added migrations for assignee_updated_date fields to Job, Project, and Task models.
cvat/apps/engine/models.py Added assignee_updated_date to Project, Task, and Job models. Modified Job.get_task_id method.
cvat/apps/engine/serializers.py Updated serializer classes to handle assignee_updated_date fields and assignee info.
cvat/apps/quality_control/migrations/... Added assignee field to QualityReport model.
cvat/apps/quality_control/models.py Introduced assignee field in QualityReport class.
cvat/apps/quality_control/quality_reports.py Modified methods related to job and task comparisons to include assignee_id. Added _serialize_assignee function.
cvat/apps/quality_control/serializers.py Added assignee field in QualityReportSerializer using BasicUserSerializer.
cvat/apps/quality_control/views.py Updated QualityReportSerializer to include request context.
cvat/schema.yml Added assignee_updated_date field to relevant components.
tests/python/rest_api/...(various) Added test methods related to creation and updates of jobs, projects, tasks, and quality reports with assignees.
tests/python/shared/assets/... Added assignee_updated_date and assignee: null fields in JSON test data files.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Frontend
    participant Backend
    participant Database

    User->>Frontend: Update assignee of a task
    Frontend->>Backend: Send update request with new assignee info
    Backend->>Database: Update task assignee and assignee_updated_date
    Database-->>Backend: Confirm update
    Backend-->>Frontend: Send confirmation of update
    Frontend-->>User: Display updated assignee information

    User->>Frontend: Request quality report
    Frontend->>Backend: Fetch quality report
    Backend->>Database: Retrieve quality report and assignee info
    Database-->>Backend: Provide quality report
    Backend-->>Frontend: Send quality report data
    Frontend-->>User: Display quality report with assignee info
Loading

Poem

Amidst the code, a change so bright,
Tracking updates through day and night.
Assignees now with dates so grand,
Projects and tasks, all set to expand.
Quality reports with clarity find,
🎉 This Rabbit's code, a trail refined! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Outside diff range and nitpick comments (5)
tests/python/rest_api/test_quality_control.py (2)

431-433: Add a docstring to the test method.

Consider adding a docstring to the test method to describe its purpose.

"""
Test that report data includes job assignees when available.
"""

500-502: Add a docstring to the test method.

Consider adding a docstring to the test method to describe its purpose.

"""
Test that reports can be created with job assignees.
"""
tests/python/rest_api/test_jobs.py (3)

314-314: Add a docstring to the test method.

Consider adding a docstring to describe the purpose of this test case.

"""
Test creating a job with and without an assignee.
"""

Line range hint 241-241:
Add a docstring to the test method.

Consider adding a docstring to describe the purpose of this test case.

"""
Test updating the assignee and the corresponding updated date.
"""

[!TIP]
Codebase Verification

Ensure proper test case coverage.

The test case test_can_update_assignee_updated_date_on_assignee_updates does not handle edge cases such as invalid assignee IDs or missing users entries. Consider adding tests to cover these scenarios.

  • File: tests/python/rest_api/test_jobs.py
  • Function: test_can_update_assignee_updated_date_on_assignee_updates
Analysis chain

Line range hint 242-270:
Ensure proper test case coverage.

The test case covers updating the assignee and verifying the updated date. Verify that it handles edge cases such as invalid assignee IDs or missing users entries.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the edge cases for updating the assignee and the corresponding updated date.

# Test: Ensure the test covers invalid assignee IDs and missing users entries.
rg --type python $'test_can_update_assignee_updated_date_on_assignee_updates'

Length of output: 107


Script:

#!/bin/bash
# Description: Verify the edge cases for updating the assignee and the corresponding updated date.

# Test: Search for the test function definition and its contents to ensure it covers invalid assignee IDs and missing users entries.
rg 'def test_can_update_assignee_updated_date_on_assignee_updates' -A 20

Length of output: 5194


Script:

#!/bin/bash
# Description: Verify the edge cases for updating the assignee and the corresponding updated date.

# Test: Search for additional lines of code in the test function definition and its contents to ensure it covers invalid assignee IDs and missing users entries.
rg 'def test_can_update_assignee_updated_date_on_assignee_updates' -A 50

Length of output: 10342

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c9f1cff and f484539.

Files selected for processing (22)
  • changelog.d/20240704_201201_mzhiltso_track_last_assignee_update.md (1 hunks)
  • cvat-core/src/quality-report.ts (4 hunks)
  • cvat-core/src/server-response-types.ts (1 hunks)
  • cvat-ui/src/components/analytics-page/task-quality/job-list.tsx (3 hunks)
  • cvat/apps/engine/migrations/0079_job_assignee_updated_date_and_more.py (1 hunks)
  • cvat/apps/engine/models.py (5 hunks)
  • cvat/apps/engine/serializers.py (13 hunks)
  • cvat/apps/engine/tests/test_rest_api.py (1 hunks)
  • cvat/apps/quality_control/migrations/0002_qualityreport_assignee.py (1 hunks)
  • cvat/apps/quality_control/models.py (3 hunks)
  • cvat/apps/quality_control/quality_reports.py (9 hunks)
  • cvat/apps/quality_control/serializers.py (3 hunks)
  • cvat/apps/quality_control/views.py (2 hunks)
  • cvat/schema.yml (4 hunks)
  • tests/python/rest_api/test_jobs.py (3 hunks)
  • tests/python/rest_api/test_projects.py (3 hunks)
  • tests/python/rest_api/test_quality_control.py (3 hunks)
  • tests/python/rest_api/test_tasks.py (3 hunks)
  • tests/python/shared/assets/jobs.json (25 hunks)
  • tests/python/shared/assets/projects.json (12 hunks)
  • tests/python/shared/assets/quality_reports.json (12 hunks)
  • tests/python/shared/assets/tasks.json (18 hunks)
Files skipped from review due to trivial changes (6)
  • changelog.d/20240704_201201_mzhiltso_track_last_assignee_update.md
  • cvat/apps/engine/migrations/0079_job_assignee_updated_date_and_more.py
  • cvat/apps/engine/tests/test_rest_api.py
  • cvat/apps/quality_control/migrations/0002_qualityreport_assignee.py
  • tests/python/shared/assets/projects.json
  • tests/python/shared/assets/tasks.json
Additional comments not posted (43)
cvat-core/src/quality-report.ts (4)

6-6: Import statement approved.

The import of the User class is correct and necessary for the new assignee property.


40-40: Property addition approved.

The assignee property is correctly defined as User | null.


52-57: Constructor logic approved.

The constructor correctly initializes the assignee property based on the initialData.


88-90: Getter method approved.

The getter method for the assignee property is correctly implemented.

cvat/apps/quality_control/serializers.py (3)

9-9: Import statement approved.

The import of BasicUserSerializer from engine_serializers is correct and necessary for the new assignee field in the QualityReportSerializer.


47-47: Field addition approved.

The assignee field is correctly defined using BasicUserSerializer.


62-62: Field integration approved.

The assignee field is correctly integrated into the fields array in the QualityReportSerializer.

cvat/apps/quality_control/models.py (2)

15-15: Import statement approved.

The import of the User model is correct and necessary for the new assignee field in the QualityReport model.


89-91: Field addition approved.

The assignee field is correctly defined as a ForeignKey to the User model with on_delete=models.SET_NULL.

cvat-ui/src/components/analytics-page/task-quality/job-list.tsx (3)

70-75: Function modification approved.

The collectUsers function correctly maps the jobsReports and returns the expected values.


130-131: Function modification approved.

The render function correctly references the report for the assignee field.


235-235: Object modification approved.

The object correctly references the report for the stage, quality, conflicts, and frame_intersection fields.

tests/python/shared/assets/quality_reports.json (6)

7-7: Addition of "assignee" field looks good.

The "assignee" field is added with a value of null, which is consistent with the rest of the data structure.


39-39: Addition of "assignee" field looks good.

The "assignee" field is added with a value of null, which is consistent with the rest of the data structure.


71-71: Addition of "assignee" field looks good.

The "assignee" field is added with a value of null, which is consistent with the rest of the data structure.


103-103: Addition of "assignee" field looks good.

The "assignee" field is added with a value of null, which is consistent with the rest of the data structure.


135-135: Addition of "assignee" field looks good.

The "assignee" field is added with a value of null, which is consistent with the rest of the data structure.


167-167: Addition of "assignee" field looks good.

The "assignee" field is added with a value of null, which is consistent with the rest of the data structure.

cvat-core/src/server-response-types.ts (1)

299-299: Addition of "assignee" field looks good.

The "assignee" field is added to the SerializedQualityReportData interface, which is consistent with the rest of the data structure and follows TypeScript best practices.

cvat/apps/quality_control/views.py (1)

314-316: Serialization of "assignee" field looks good.

The added lines correctly serialize the assignee field in the create method of the QualityReportViewSet class, following Django best practices.

tests/python/shared/assets/jobs.json (1)

8-8: Addition of "assignee_updated_date" field looks good.

The "assignee_updated_date" field is added with a value of null, which is consistent with the rest of the data structure.

Also applies to: 41-41, 74-74, 107-107, 140-140, 173-173, 206-206, 247-247, 288-288, 329-329, 370-370, 411-411, 444-444, 485-485, 526-526, 565-565, 606-606, 639-639, 672-672, 711-711, 750-750, 783-783, 816-816, 855-855, 894-894

cvat/apps/engine/models.py (4)

334-335: Approved: Added assignee_updated_date field to Project class.

The addition of the assignee_updated_date field is correctly implemented as a DateTimeField with null=True, blank=True, and default=None.


407-407: Approved: Added assignee_updated_date field to Task class.

The addition of the assignee_updated_date field is correctly implemented as a DateTimeField with null=True, blank=True, and default=None.


670-670: Approved: Added assignee_updated_date field to Job class.

The addition of the assignee_updated_date field is correctly implemented as a DateTimeField with null=True, blank=True, and default=None.


714-714: Approved: Updated get_task_id method in Job class.

The get_task_id method now correctly returns self.segment.task_id.

tests/python/rest_api/test_projects.py (2)

498-515: Approved: Added test for project creation with assignee.

The test correctly verifies the assignee and assignee_updated_date fields during project creation.


1170-1198: Approved: Added test for updating assignee_updated_date on assignee updates.

The test correctly verifies the behavior of the assignee_updated_date field when the assignee is updated.

cvat/apps/quality_control/quality_reports.py (1)

Line range hint 2490-2508:
LGTM!

The changes correctly integrate the serialized assignee data into the report.

cvat/apps/engine/serializers.py (9)

595-595: LGTM! The new field assignee_updated_date is correctly added.

The addition of the assignee_updated_date field is appropriate and aligns with the rest of the serializer.


752-762: LGTM! The assignee_updated_date field is correctly handled during job creation.

The field is correctly set to the job's updated date when an assignee is assigned.


781-785: LGTM! The assignee_updated_date field is correctly handled during job updates.

The field is correctly updated to the current time when the assignee changes.


1114-1114: LGTM! The new field assignee_updated_date is correctly added.

The addition of the assignee_updated_date field is appropriate and aligns with the rest of the serializer.


1198-1200: LGTM! The assignee_updated_date field is correctly handled during task creation.

The field is correctly set to the task's updated date when an assignee is assigned.


1213-1219: LGTM! The assignee_updated_date field is correctly handled during task updates.

The field is correctly updated to the current time when the assignee changes.


1345-1345: LGTM! The new field assignee_updated_date is correctly added.

The addition of the assignee_updated_date field is appropriate and aligns with the rest of the serializer.


1413-1416: LGTM! The assignee_updated_date field is correctly handled during project creation.

The field is correctly set to the project's updated date when an assignee is assigned.


1426-1432: LGTM! The assignee_updated_date field is correctly handled during project updates.

The field is correctly updated to the current time when the assignee changes.

tests/python/rest_api/test_tasks.py (2)

415-432: LGTM!

The test function test_can_create_with_assignee is well-structured and covers the necessary cases for testing task creation with and without an assignee.


2677-2706: LGTM!

The test function test_can_update_assignee_updated_date_on_assignee_updates is comprehensive and covers various scenarios for updating the assignee, ensuring the assignee_updated_date is correctly managed.

cvat/schema.yml (4)

8095-8098: Addition of assignee_updated_date field in JobRead schema.

The new field assignee_updated_date has been added to the JobRead schema. This field is of type string, with format date-time, and is nullable. It is correctly defined to track the last update time of the assignee.


9577-9580: Addition of assignee_updated_date field in ProjectRead schema.

The new field assignee_updated_date has been added to the ProjectRead schema. This field is of type string, with format date-time, and is nullable. It is correctly defined to track the last update time of the assignee.


10443-10446: Addition of assignee_updated_date field in TaskRead schema.

The new field assignee_updated_date has been added to the TaskRead schema. This field is of type string, with format date-time, and is nullable. It is correctly defined to track the last update time of the assignee.


9678-9682: Addition of assignee field in QualityReport schema.

The new field assignee has been added to the QualityReport schema. This field references BasicUser and is nullable. It is correctly defined to track the assignee of the quality report.

Comment on lines 2490 to 2498
def _serialize_assignee(assignee: Optional[User]) -> Optional[dict]:
if not db_report.assignee:
return None

reported_keys = ["id", "username", "first_name", "last_name"]
assert set(reported_keys).issubset(engine_serializers.BasicUserSerializer.Meta.fields)
# check that only safe fields are reported

return {k: getattr(assignee, k) for k in reported_keys}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a serializer for consistency.

While the current implementation is correct, using engine_serializers.BasicUserSerializer directly would ensure consistency with other parts of the codebase.

- def _serialize_assignee(assignee: Optional[User]) -> Optional[dict]:
-     if not db_report.assignee:
-         return None
-     reported_keys = ["id", "username", "first_name", "last_name"]
-     assert set(reported_keys).issubset(engine_serializers.BasicUserSerializer.Meta.fields)
-     return {k: getattr(assignee, k) for k in reported_keys}

+ def _serialize_assignee(assignee: Optional[User]) -> Optional[dict]:
+     if not assignee:
+         return None
+     return engine_serializers.BasicUserSerializer(assignee).data
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
def _serialize_assignee(assignee: Optional[User]) -> Optional[dict]:
if not db_report.assignee:
return None
reported_keys = ["id", "username", "first_name", "last_name"]
assert set(reported_keys).issubset(engine_serializers.BasicUserSerializer.Meta.fields)
# check that only safe fields are reported
return {k: getattr(assignee, k) for k in reported_keys}
def _serialize_assignee(assignee: Optional[User]) -> Optional[dict]:
if not assignee:
return None
return engine_serializers.BasicUserSerializer(assignee).data

Comment on lines 451 to 458
if bool(normal_job["assignee"]) != has_assignee:
with make_api_client(admin_user) as api_client:
api_client.jobs_api.partial_update(
normal_job["id"],
patched_job_write_request={
"assignee": new_assignee["id"] if new_assignee else None
},
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a context manager for updating the job assignee.

Using a context manager ensures that the API client is properly closed after the update.

with make_api_client(admin_user) as api_client:
    api_client.jobs_api.partial_update(
        normal_job["id"],
        patched_job_write_request={
            "assignee": new_assignee["id"] if new_assignee else None
        },
    )

Comment on lines 467 to 483
report_data = json.loads(self._test_get_report_data_200(admin_user, job_report["id"]).data)
assert (
DeepDiff(
(
{
k: v
for k, v in new_assignee.items()
if k in ["id", "username", "first_name", "last_name"]
}
if new_assignee
else None
),
report_data["assignee"],
)
== {}
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the assertion for assignee comparison.

The assertion can be simplified by directly comparing the expected and actual assignee data.

expected_assignee = (
    {k: v for k, v in new_assignee.items() if k in ["id", "username", "first_name", "last_name"]}
    if new_assignee
    else None
)
assert DeepDiff(expected_assignee, report_data["assignee"]) == {}

Comment on lines 515 to 521
with make_api_client(admin_user) as api_client:
api_client.jobs_api.partial_update(
normal_job["id"],
patched_job_write_request={
"assignee": users_by_name[admin_user]["id"] if has_assignee else None
},
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a context manager for updating the job assignee.

Using a context manager ensures that the API client is properly closed after the update.

with make_api_client(admin_user) as api_client:
    api_client.jobs_api.partial_update(
        normal_job["id"],
        patched_job_write_request={
            "assignee": users_by_name[admin_user]["id"] if has_assignee else None
        },
    )

Comment on lines 315 to 340
def test_can_create_with_assignee(self, admin_user, tasks, jobs, users_by_name, assignee):
task = next(
t
for t in tasks
if t["size"] > 0
if all(j["type"] != "ground_truth" for j in jobs if j["task_id"] == t["id"])
)

spec = {
"task_id": task["id"],
"type": "ground_truth",
"frame_selection_method": "random_uniform",
"frame_count": 1,
"assignee": users_by_name[assignee]["id"] if assignee else None,
}

with make_api_client(admin_user) as api_client:
(job, _) = api_client.jobs_api.create(job_write_request=spec)

if assignee:
assert job.assignee.username == assignee
assert job.assignee_updated_date
else:
assert job.assignee is None
assert job.assignee_updated_date is None

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Ensure proper test case coverage.

The test_can_create_with_assignee function tests job creation with and without an assignee. However, it does not cover edge cases such as invalid assignee IDs or missing users_by_name entries. Please add test cases to handle these scenarios.

  • Verify behavior when users_by_name does not contain the assignee.
  • Verify behavior when the assignee ID is invalid.
Analysis chain

Ensure proper test case coverage.

The test case covers job creation with and without an assignee. Verify that it handles edge cases such as invalid assignee IDs or missing users_by_name entries.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the edge cases for job creation with an assignee.

# Test: Ensure the test covers invalid assignee IDs and missing users_by_name entries.
rg --type python $'test_can_create_with_assignee'

Length of output: 79


Script:

#!/bin/bash
# Description: Verify the edge cases for job creation with an assignee.

# Correcting the `rg` command to search for the test case `test_can_create_with_assignee`.
rg 'def test_can_create_with_assignee' --glob '*.py'

Length of output: 423


Script:

#!/bin/bash
# Extract the content of the `test_can_create_with_assignee` function from `tests/python/rest_api/test_jobs.py`.
ast-grep --lang python --pattern $'def test_can_create_with_assignee(self, admin_user, tasks, jobs, users_by_name, assignee):\n    $$$' tests/python/rest_api/test_jobs.py

Length of output: 2074

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI part looks ok

Co-authored-by: Kirill Lakhov <kirill.9992@gmail.com>
@zhiltsov-max zhiltsov-max changed the title [Dependent] Show job assignee from quality reports in UI Show job assignee from quality reports in UI Jul 15, 2024
@zhiltsov-max
Copy link
Contributor Author

/check

Copy link
Contributor

github-actions bot commented Jul 15, 2024

❌ Some checks failed
📄 See logs here

Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.40%. Comparing base (f1664c6) to head (e47dc79).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8123      +/-   ##
===========================================
- Coverage    83.40%   83.40%   -0.01%     
===========================================
  Files          388      388              
  Lines        41299    41305       +6     
  Branches      3852     3854       +2     
===========================================
+ Hits         34446    34450       +4     
- Misses        6853     6855       +2     
Components Coverage Δ
cvat-ui 79.63% <66.66%> (-0.01%) ⬇️
cvat-server 86.78% <ø> (+<0.01%) ⬆️

@zhiltsov-max zhiltsov-max merged commit a9f50d1 into develop Jul 16, 2024
33 checks passed
@zhiltsov-max zhiltsov-max deleted the zm/assignee-from-quality-reports-in-ui branch July 17, 2024 09:10
@cvat-bot cvat-bot bot mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants