-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Smokescreen proxy for annotation worker, same as for export worker #8199
Enable Smokescreen proxy for annotation worker, same as for export worker #8199
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes introduce a new program configuration for "smokescreen" within the supervisord management system. This enhancement allows supervisord to manage the smokescreen process, specifying its command and parameters, which improves service management capabilities. The overall structure of the configuration file remains unchanged, ensuring seamless integration of the new feature. Changes
Sequence Diagram(s)(No sequence diagrams generated as the changes are straightforward and do not necessitate visual representation.) Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- supervisord/worker.annotation.conf (1 hunks)
Additional comments not posted (2)
supervisord/worker.annotation.conf (2)
27-27
: New program configuration for smokescreen added.The introduction of the
[program:smokescreen]
section aligns with the PR objective to enable the Smokescreen proxy for the annotation worker. This addition enhances the proxy capabilities and is well-structured.
29-29
: Command for smokescreen program specified correctly.The command
smokescreen --listen-ip=127.0.0.1 %(ENV_SMOKESCREEN_OPTS)s
is correctly defined, ensuring that the Smokescreen proxy will run with the appropriate settings.
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8199 +/- ##
==========================================
Coverage ? 83.37%
==========================================
Files ? 388
Lines ? 41305
Branches ? 3854
==========================================
Hits ? 34437
Misses ? 6868
Partials ? 0
|
…rker
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit