-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation management core #8471
Conversation
…_job and manual frame selection
|
||
def init_chunks_updated_date(apps, schema_editor): | ||
# The 0083 migration changed data distribution by chunks | ||
migration_0083_date = _get_0083_move_to_segment_chunks_migration_date(apps, schema_editor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use current datetime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just task_created_date
as done below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this will be incorrect.
If the task was created before the migration, it's chunks were updated when the migration was applied (maybe several days before the current migration is applied).
If the task was created after the migration, it's chunks were updated at the moment of task creation.
Neither of this is now
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct enough, as the feature to upgrade chunks (shuffle honeypots) was not merged yet.
chunks were updated when the migration was applied
How exactly these chunks were updated in the migration? They only were re-numerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How exactly these chunks were updated in the migration? They only were re-numerated.
No, the chunks on the end of the segment could be truncated, and for videos with overlap there were entirely new chunks.
@@ -115,6 +116,9 @@ | |||
|
|||
_UPLOAD_PARSER_CLASSES = api_settings.DEFAULT_PARSER_CLASSES + [MultiPartParser] | |||
|
|||
_DATA_CHECKSUM_HEADER_NAME = 'X-Checksum' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this checksum supposed to be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be used to check if the downloaded chunk has the same checksum as the one cached, if there are any locally cached ones. Some job chunks may be unaffected by the latest update.
Need to integrate tasks with honeypots with Review mode in UI. Basically, need to retrieve job |
|
||
# Guarantee uniformness by using a known distribution | ||
# overall task honeypot distribution is not guaranteed though | ||
rng = random.Generator(random.MT19937()) |
Check notice
Code scanning / SonarCloud
Results that depend on random number generation should be reproducible Low
Quality Gate passedIssues Measures |
Motivation and context
Depends on #8348
Includes / depends on #8510
gt_pool
)GET /api/tasks/{id}/validation_layout
- allows getting validation configuration in the taskGET /api/jobs/{id}/validation_layout
- allows getting validation configuration in the job (available only to the task assignee and above)PATCH /api/tasks/{id}/validation_layout
- allows exclusion of validation frames and changing real frames for honeypots in the taskPATCH /api/jobs/{id}/validation_layout
- allows changing real frames for honeypots in the job (available only to the task assignee and above)How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
ValidationMethod
toValidationMode
across various components.Chores