Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi tasks docs #8516

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Update multi tasks docs #8516

merged 5 commits into from
Oct 11, 2024

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Oct 7, 2024

Motivation and context

  • Updated styles on create multi tasks form. Margin seems to be too large, reduced it a bit
    image
    image
  • Updated documentation text (there was some weird description about underscores if task has name with several words, but cvat doesnt have such restrictions, we can use spaces) + some minor fixes
  • Updated documentation screenshots with new UI

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Enhanced user interface for task name fields with clearer tooltip instructions.
    • Updated documentation for creating multi-tasks and annotation tasks, improving clarity and usability.
  • Bug Fixes

    • Updated visual references in documentation to ensure relevance and clarity.
  • Documentation

    • Improved instructions and visuals in the "Create multi tasks" and "Create annotation task" manuals.

@klakhov klakhov added documentation Documentation should be updated ui/ux labels Oct 7, 2024
@klakhov klakhov requested a review from bsekachev as a code owner October 7, 2024 08:43
Copy link
Contributor

coderabbitai bot commented Oct 7, 2024

Walkthrough

The changes include updates to the BasicConfigurationForm component in basic-configuration-form.tsx, where a new class name is conditionally added and tooltip text is modified. In styles.scss, a new CSS class is introduced for styling task name fields with tooltips. Documentation updates in create-multi-tasks.md and create_an_annotation_task.md enhance clarity, update visuals, and provide more detailed instructions on creating tasks and annotations, including new images and refined explanations.

Changes

File Path Change Summary
cvat-ui/src/components/create-task-page/basic-configuration-form.tsx Updated copyright notice, added conditional class name cvat-task-name-field-has-tooltip, modified tooltip text.
cvat-ui/src/components/create-task-page/styles.scss Added new CSS class .cvat-task-name-field-has-tooltip with margin-bottom property.
site/content/en/docs/manual/basics/create-multi-tasks.md Enhanced clarity, updated visuals, simplified instructions, and replaced images for better guidance.
site/content/en/docs/manual/basics/create_an_annotation_task.md Expanded details on task creation, refined sections on labels and attributes, added structured tables for clarity.

Poem

In the land of tasks, where bunnies play,
New tools and tips brighten the day.
With clearer paths and visuals bright,
We hop along, with pure delight! 🐇✨
Let's create with joy, in every way,
For every task, a fun-filled sway!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (9)
cvat-ui/src/components/create-task-page/styles.scss (1)

42-44: LGTM! Consider adding a comment for clarity.

The addition of the .cvat-task-name-field-has-tooltip class aligns well with the PR objective of adjusting UI styles. The use of $grid-unit-size maintains consistency with existing styling conventions.

Consider adding a brief comment above the class to explain its purpose, for example:

// Adjust spacing for task name fields with tooltips
.cvat-task-name-field-has-tooltip {
    margin-bottom: $grid-unit-size;
}

This would enhance code readability and maintainability.

site/content/en/docs/manual/basics/create-multi-tasks.md (2)

28-28: LGTM: Improved task configurator instructions.

The updates enhance clarity and provide more accurate visual guidance. The simplification of task naming instructions is particularly helpful.

Consider adding a brief explanation of what the {{index}} and {{file_name}} placeholders do, for example:

- (Optional) `{{index}}` adds a sequential number to the task name (starting from 0).
- (Optional) `{{file_name}}` incorporates the original file name into the task name.

This would provide users with a clearer understanding of these optional parameters.

Also applies to: 34-35, 41-41


90-91: LGTM: Updated error section with refined descriptions.

The updates to the error section, including new image references and refined descriptions, improve the overall clarity of the documentation.

Consider this minor wording improvement for better readability:

-In the process of creating a task, CVAT was not able to process the video file.
+In the process of creating a task, CVAT was unable to process the video file.

This change makes the sentence more concise and formal.

🧰 Tools
🪛 LanguageTool

[style] ~91-~91: Consider using “unable” to avoid wordiness.
Context: ...he process of creating a task, CVAT was not able to process the video file.
The name...

(NOT_ABLE_PREMIUM)


[style] ~91-~91: Consider using a different verb for a more formal wording.
Context: ...played on the progress bar.

To fix this issue:

  • If you want to try aga...

    (FIX_RESOLVE)


    [style] ~91-~91: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
    Context: ...ick Retry failed tasks.

  • If you want to skip the file, click OK. | <!--lin...

    (REP_WANT_TO_VB)

  • site/content/en/docs/manual/basics/create_an_annotation_task.md (6)

    40-41: LGTM. Don't forget to update the image.

    The placeholder comment is a good reminder for updating the image in the future. Ensure that the new image accurately represents the project selection process when it's ready.

    Consider adding a TODO comment in your project management tool to track this image update task.


    Line range hint 73-108: Excellent expansion of the Label shape section.

    The added content significantly improves the understanding of label shapes and their impact on the annotation process. The examples and explanations are clear and informative.

    Consider adding a brief note about the performance implications (if any) of choosing different label shapes. This could help users make more informed decisions when setting up their tasks.


    Line range hint 110-166: Great improvement in the Add an attribute section.

    The expanded content provides a much clearer explanation of attributes, their types, and how to add them. The step-by-step instructions and examples are particularly helpful.

    Consider adding a brief note about best practices for naming attributes. This could help users create more consistent and easily understandable attribute names across their projects.


    Line range hint 168-186: Excellent restructuring of the Select files section.

    The new table format greatly improves the readability and organization of information about different file upload methods. The descriptions are concise yet informative.

    Consider adding a brief note about any file size limitations or supported file formats for each upload method. This could help users avoid potential issues when uploading their data.


    Line range hint 246-328: Excellent expansion of the Advanced configuration section.

    The new table format provides a comprehensive and well-structured overview of the advanced configuration parameters. The explanations are clear, detailed, and include practical examples where needed.

    Consider adding a brief note at the beginning of this section to caution users about modifying these advanced settings without a thorough understanding of their implications. This could help prevent unintended consequences for less experienced users.


    Line range hint 1-328: Outstanding improvements to the Create annotation task documentation.

    The extensive revisions and additions throughout this document significantly enhance its clarity, completeness, and overall usefulness. The expanded sections, new examples, and improved structure make the process of creating annotation tasks much more accessible to users of all experience levels.

    Consider adding a "Quick Start" or "TL;DR" section at the beginning of the document, summarizing the essential steps for creating a basic annotation task. This could help experienced users quickly refresh their memory while still providing detailed information for those who need it.

    📜 Review details

    Configuration used: CodeRabbit UI
    Review profile: CHILL

    📥 Commits

    Files that changed from the base of the PR and between 3cde309 and 9d240c3.

    ⛔ Files ignored due to path filters (18)
    • site/content/en/images/create_multi_tasks_1.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_2.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_3.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_4.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_5.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_6.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_7.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_8.png is excluded by !**/*.png
    • site/content/en/images/create_multi_tasks_9.png is excluded by !**/*.png
    • site/content/en/images/image254.jpg is excluded by !**/*.jpg
    • site/content/en/images/image257.jpg is excluded by !**/*.jpg
    • site/content/en/images/image258.jpg is excluded by !**/*.jpg
    • site/content/en/images/image260.jpg is excluded by !**/*.jpg
    • site/content/en/images/image261.jpg is excluded by !**/*.jpg
    • site/content/en/images/image262.jpg is excluded by !**/*.jpg
    • site/content/en/images/image263.jpg is excluded by !**/*.jpg
    • site/content/en/images/multitask_configurator.png is excluded by !**/*.png
    • site/content/en/images/select_project.png is excluded by !**/*.png
    📒 Files selected for processing (4)
    • cvat-ui/src/components/create-task-page/basic-configuration-form.tsx (3 hunks)
    • cvat-ui/src/components/create-task-page/styles.scss (1 hunks)
    • site/content/en/docs/manual/basics/create-multi-tasks.md (4 hunks)
    • site/content/en/docs/manual/basics/create_an_annotation_task.md (1 hunks)
    🧰 Additional context used
    🪛 LanguageTool
    site/content/en/docs/manual/basics/create-multi-tasks.md

    [misspelling] ~13-~13: This word is normally spelled as one.
    Context: ...ulti tasks**. > Note: The Сreate multi tasks feature is available for videos only....

    (EN_COMPOUNDS_MULTI_TASKS)


    [style] ~91-~91: Consider using “unable” to avoid wordiness.
    Context: ...he process of creating a task, CVAT was not able to process the video file.
    The name...

    (NOT_ABLE_PREMIUM)


    [style] ~91-~91: Consider using a different verb for a more formal wording.
    Context: ...played on the progress bar.

    To fix this issue:

  • If you want to try aga...

    (FIX_RESOLVE)


    [style] ~91-~91: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
    Context: ...ick Retry failed tasks.

  • If you want to skip the file, click OK. | <!--lin...

    (REP_WANT_TO_VB)

  • 🔇 Additional comments (6)
    cvat-ui/src/components/create-task-page/basic-configuration-form.tsx (3)

    2-2: Copyright notice updated correctly.

    The copyright notice has been appropriately updated to reflect the current year range and the new copyright holder.


    77-77: UI and documentation improvements implemented correctly.

    The changes enhance the user interface and improve the clarity of instructions:

    1. The conditional class name cvat-task-name-field-has-tooltip allows for specific styling when the tooltip is present.
    2. The updated tooltip text "You can use in the template:" is more direct and clear.

    These modifications align well with the PR objectives of UI adjustments and documentation improvements.

    Also applies to: 98-98


    2-2: Changes align well with PR objectives.

    The modifications in this file successfully address two main objectives of the PR:

    1. UI Adjustments: The new conditional class name allows for improved styling of the task name field.
    2. Documentation Improvements: The updated tooltip text provides clearer instructions for users.

    These changes, along with the copyright update, contribute to an enhanced user experience and more accurate documentation.

    Also applies to: 77-77, 98-98

    site/content/en/docs/manual/basics/create-multi-tasks.md (3)

    15-15: LGTM: Updated image reference.

    The image update aligns with the PR objective to refresh visuals, likely providing a more accurate representation of the current UI.


    65-65: LGTM: Updated example section visuals.

    The image updates in the example section align with the PR objective to refresh visuals. These changes likely provide users with a more accurate representation of the current UI and process flow.

    Also applies to: 68-68, 72-72, 76-76, 80-80


    Line range hint 1-108: Overall assessment: Documentation improvements are well-implemented.

    The changes in this file successfully address the PR objectives:

    1. The documentation text has been revised to improve clarity and accuracy.
    2. Visual references (screenshots) have been updated to reflect the current UI.
    3. The layout and structure of the document have been enhanced for better readability.

    A few minor suggestions were made to further improve the content. Once these are addressed, the updated documentation should provide users with a more accurate and helpful guide for creating multiple tasks in CVAT.

    @codecov-commenter
    Copy link

    codecov-commenter commented Oct 7, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 74.29%. Comparing base (5f27977) to head (c7050fd).

    Additional details and impacted files
    @@             Coverage Diff             @@
    ##           develop    #8516      +/-   ##
    ===========================================
    - Coverage    74.33%   74.29%   -0.04%     
    ===========================================
      Files          397      397              
      Lines        43139    43139              
      Branches      3905     3905              
    ===========================================
    - Hits         32066    32052      -14     
    - Misses       11073    11087      +14     
    Components Coverage Δ
    cvat-ui 78.61% <ø> (-0.08%) ⬇️
    cvat-server 70.62% <ø> (ø)

    Copy link

    sonarqubecloud bot commented Oct 9, 2024

    @bsekachev bsekachev merged commit ea5955a into develop Oct 11, 2024
    34 checks passed
    @klakhov klakhov deleted the kl/update-multi-tasks-docs branch October 11, 2024 08:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Documentation should be updated ui/ux
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants