Disable auto quality updates #8790
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes in this pull request involve the removal of automatic quality report updates and related functionalities across multiple files in the CVAT application. Key modifications include the deletion of specific methods and settings associated with automatic quality checks, as well as the removal of signal receivers that previously updated quality metrics. Additionally, the development and testing configurations have been updated, including changes to the handling of quality check delays. Documentation has also been revised to clarify the automated quality assurance process. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Task
participant QualityControl
participant QualityReportUpdateManager
User->>Task: Create Task
Task->>QualityControl: Initialize Quality Settings
QualityControl->>QualityReportUpdateManager: Schedule Custom Quality Check Job
QualityReportUpdateManager-->>QualityControl: Confirm Scheduling
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
cvat/apps/quality_control/signals.py (1)
Line range hint
17-19: Replaceassert Falsewith a more informative exceptionUsing
assert Falsemay not provide a helpful error message and can be omitted in optimized code. Consider raising an explicit exception with a descriptive message to handle unexpected instance types.Apply this diff to improve error handling:
else: - assert False + raise ValueError(f"Unexpected instance type: {type(instance)}")site/content/en/docs/manual/advanced/analytics-and-monitoring/auto-qa.md (1)
501-501: Add missing preposition 'of' in the sentenceThe sentence is missing the preposition 'of' after 'update'. It should read: 'If you want to request an update of quality metrics in a task...'
Apply this change to correct the sentence:
-If you want to request an update quality metrics in a task (e.g. after the settings were changed), +If you want to request an update of quality metrics in a task (e.g. after the settings were changed),🧰 Tools
🪛 LanguageTool
[uncategorized] ~501-~501: Possible missing preposition found.
Context: ...tton. If you want to request an update quality metrics in a task (e.g. after the setti...(AI_HYDRA_LEO_MISSING_OF)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (9)
changelog.d/20241207_024832_mzhiltso_disable_auto_quality_updates.md(1 hunks)cvat/apps/analytics_report/report/create.py(0 hunks)cvat/apps/quality_control/apps.py(0 hunks)cvat/apps/quality_control/default_settings.py(0 hunks)cvat/apps/quality_control/quality_reports.py(0 hunks)cvat/apps/quality_control/signals.py(1 hunks)cvat/settings/development.py(0 hunks)cvat/settings/testing_rest.py(0 hunks)site/content/en/docs/manual/advanced/analytics-and-monitoring/auto-qa.md(1 hunks)
💤 Files with no reviewable changes (6)
- cvat/apps/quality_control/default_settings.py
- cvat/settings/testing_rest.py
- cvat/apps/analytics_report/report/create.py
- cvat/apps/quality_control/apps.py
- cvat/settings/development.py
- cvat/apps/quality_control/quality_reports.py
✅ Files skipped from review due to trivial changes (1)
- changelog.d/20241207_024832_mzhiltso_disable_auto_quality_updates.md
🧰 Additional context used
🪛 LanguageTool
site/content/en/docs/manual/advanced/analytics-and-monitoring/auto-qa.md
[uncategorized] ~501-~501: Possible missing preposition found.
Context: ...tton. If you want to request an update quality metrics in a task (e.g. after the setti...
(AI_HYDRA_LEO_MISSING_OF)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8790 +/- ##
===========================================
- Coverage 73.96% 73.91% -0.05%
===========================================
Files 409 408 -1
Lines 43942 43884 -58
Branches 3985 3986 +1
===========================================
- Hits 32500 32436 -64
- Misses 11442 11448 +6
|
bsekachev
requested review from
bsekachev
and removed request for
nmanovic and
Marishka17
site/content/en/docs/manual/advanced/analytics-and-monitoring/auto-qa.md
Outdated
Show resolved
Hide resolved
site/content/en/docs/manual/advanced/analytics-and-monitoring/auto-qa.md
Outdated
Show resolved
Hide resolved
changelog.d/20241207_024832_mzhiltso_disable_auto_quality_updates.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Sekachev <boris.sekachev@yandex.ru>
|
Motivation and context
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
Chores