Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed installation of YOLOv7 on GPU #8824

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Dec 12, 2024

Motivation and context

Resolved #8503

older onnxruntime-gpu is not compatible with numpy > 2.0
one solution is to fix numpy to older version
another solution (in pull request) is to update onnxruntime-gpu

Newest version of onnxruntime-gpu available in PyPI requires Cuda 12

If you have difficulties with setup, try:

  • To update NVIDIA driver (mine is 566.36)
  • To update Docker version (mine is 27.4.0)
  • To update Nvidia Toolkit (mine is 1.17.3)

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Added a changelog entry for the installation of YOLOv7 on GPU.
  • Bug Fixes

    • Updated the configuration for the serverless function to improve performance and compatibility with the latest CUDA and ONNX runtime versions.

@bsekachev bsekachev requested a review from nmanovic as a code owner December 12, 2024 19:32
Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request introduces a changelog entry documenting a fix for the installation of YOLOv7 on GPU and modifies the configuration of a serverless function. The changes include an upgrade of the CUDA base image and the onnxruntime-gpu package version in the function-gpu.yaml file. The updates aim to enhance the performance and compatibility of the YOLOv7 model without altering its core functionality.

Changes

File Change Summary
changelog.d/20241212_212647_sekachev.bs_fixed_serverless_func.md Added changelog entry for "Installation of YOLOv7 on GPU".
serverless/onnx/WongKinYiu/yolov7/nuclio/function-gpu.yaml Updated baseImage to nvidia/cuda:12.6.3-cudnn-runtime-ubuntu22.04 and onnxruntime-gpu version to 1.20.*.

Assessment against linked issues

Objective Addressed Explanation
Resolution of segmentation fault and compatibility issues for auto-annotation (#8503) The changes do not address the segmentation fault or compatibility with NumPy.

🐰 In the meadow where the bunnies play,
A fix for YOLOv7 came our way!
With CUDA upgraded, oh what a sight,
Our models will run with all their might!
Hopping along, we celebrate this cheer,
For smoother annotations, we hold dear! 🥕✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (289ad43) to head (877504d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8824      +/-   ##
===========================================
- Coverage    73.93%   73.90%   -0.03%     
===========================================
  Files          409      409              
  Lines        43930    43930              
  Branches      3986     3986              
===========================================
- Hits         32478    32465      -13     
- Misses       11452    11465      +13     
Components Coverage Δ
cvat-ui 78.36% <ø> (+0.02%) ⬆️
cvat-server 70.07% <ø> (-0.08%) ⬇️

@bsekachev bsekachev merged commit c729f18 into develop Dec 13, 2024
35 checks passed
@cvat-bot cvat-bot bot mentioned this pull request Dec 20, 2024
@bsekachev bsekachev deleted the bs/fixed_serverless_func branch January 10, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error occurs when auto-annotation is executed using serverless yolov7-gpu
2 participants