Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added in OpenVINO road semantic segmentation #890

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

benhoff
Copy link
Contributor

@benhoff benhoff commented Dec 3, 2019

No description provided.

@nmanovic
Copy link
Contributor

nmanovic commented Dec 3, 2019

@benhoff , it is a great contribution as usual. Thanks for all your time. Let's clarify a couple of questions and merge.

@benhoff benhoff changed the title added in OpenVINO road semantic segmentation [WIP] added in OpenVINO road semantic segmentation Dec 3, 2019
@benhoff
Copy link
Contributor Author

benhoff commented Dec 3, 2019

I'm not sure about the background thing. Let me take a look.

@benhoff benhoff changed the title [WIP] added in OpenVINO road semantic segmentation added in OpenVINO road semantic segmentation Dec 9, 2019
@benhoff
Copy link
Contributor Author

benhoff commented Dec 9, 2019

@nmanovic , I couldn't find any documentation about a background instance.

However, the demo in the open_model_zoo seems to suggest there is a 20th index.

See here: https://github.com/opencv/open_model_zoo/blob/e372d4173e50741a6828cda415d55c37320f89cd/demos/python_demos/segmentation_demo/segmentation_demo.py#L140

Doing some testing on an image I have locally seems to suggest that the first index is a road. The other labels seem to line up well with the mappings as they are.

An extra index shouldn't hurt anything if it's wrong, so I slotted the 20th index as a "background" label.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit a2a03d2 into cvat-ai:develop Dec 10, 2019
@nmanovic
Copy link
Contributor

@benhoff , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants