Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lambda function logic when all detections are filtered out #8931

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

SpecLad
Copy link
Contributor

@SpecLad SpecLad commented Jan 13, 2025

Motivation and context

Currently, if all detected shapes have labels that aren't mapped, then the mapping is not applied at all.

How has this been tested?

Manual testing.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [ ] I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • Bug Fixes

    • Improved lambda function response handling to correctly filter out detections with unmapped labels.
  • Tests

    • Added a new test case to validate handling of unmapped shapes in detector functions.

Copy link
Contributor

coderabbitai bot commented Jan 13, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes address a specific issue in the lambda function handling within the CVAT (Computer Vision Annotation Tool) application. The modification focuses on improving the filtering mechanism for detector functions, ensuring that only shapes with mapped labels are processed and returned. A new test case has been added to validate the behavior when all detected shapes have unmapped labels, resulting in an empty response.

Changes

File Change Summary
cvat/apps/lambda_manager/tests/test_lambda.py Added new test method test_api_v2_lambda_functions_create_detector_all_shapes_unmapped to verify handling of unmapped shapes
cvat/apps/lambda_manager/views.py Enhanced response filtering for detector functions to process only shapes with mapped labels
changelog.d/20250113_122208_roman_filter_out_all_detections.md Documented the fix for lambda function behavior with unmapped shapes

Sequence Diagram

sequenceDiagram
    participant Client
    participant LambdaFunction
    participant Detector
    participant ResponseFilter

    Client->>LambdaFunction: Invoke detector
    LambdaFunction->>Detector: Request detection
    Detector-->>LambdaFunction: Return all detections
    LambdaFunction->>ResponseFilter: Filter detections by mapping
    ResponseFilter-->>LambdaFunction: Return filtered detections
    LambdaFunction-->>Client: Send filtered response
Loading

Poem

🐰 In the realm of lambda's might,
Where shapes dance in detection's light,
No label left behind, no shape astray,
Our filter works its magic today!
Mapping shapes with rabbit's grace,
Code hops forward with a smile on its face! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpecLad SpecLad force-pushed the filter-out-all-detections branch from de83008 to 18eda4f Compare January 13, 2025 10:35
@SpecLad SpecLad marked this pull request as ready for review January 13, 2025 10:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (42bc345) to head (3a3d523).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8931   +/-   ##
========================================
  Coverage    73.85%   73.85%           
========================================
  Files          412      412           
  Lines        44262    44258    -4     
  Branches      3993     3993           
========================================
- Hits         32688    32686    -2     
+ Misses       11574    11572    -2     
Components Coverage Δ
cvat-ui 78.39% <ø> (-0.03%) ⬇️
cvat-server 70.00% <100.00%> (+0.02%) ⬆️

Currently, if all detected shapes have labels that aren't mapped, then the
mapping is not applied at all.
@SpecLad SpecLad force-pushed the filter-out-all-detections branch from 18eda4f to db24c1d Compare January 13, 2025 15:57
@SpecLad SpecLad merged commit a701863 into cvat-ai:develop Jan 14, 2025
35 checks passed
@SpecLad SpecLad deleted the filter-out-all-detections branch January 14, 2025 16:12
@cvat-bot cvat-bot bot mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants