-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda function logic when all detections are filtered out #8931
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes address a specific issue in the lambda function handling within the CVAT (Computer Vision Annotation Tool) application. The modification focuses on improving the filtering mechanism for detector functions, ensuring that only shapes with mapped labels are processed and returned. A new test case has been added to validate the behavior when all detected shapes have unmapped labels, resulting in an empty response. Changes
Sequence DiagramsequenceDiagram
participant Client
participant LambdaFunction
participant Detector
participant ResponseFilter
Client->>LambdaFunction: Invoke detector
LambdaFunction->>Detector: Request detection
Detector-->>LambdaFunction: Return all detections
LambdaFunction->>ResponseFilter: Filter detections by mapping
ResponseFilter-->>LambdaFunction: Return filtered detections
LambdaFunction-->>Client: Send filtered response
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
de83008
to
18eda4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8931 +/- ##
========================================
Coverage 73.85% 73.85%
========================================
Files 412 412
Lines 44262 44258 -4
Branches 3993 3993
========================================
- Hits 32688 32686 -2
+ Misses 11574 11572 -2
|
Currently, if all detected shapes have labels that aren't mapped, then the mapping is not applied at all.
18eda4f
to
db24c1d
Compare
Fix typo in changelog
|
Motivation and context
Currently, if all detected shapes have labels that aren't mapped, then the mapping is not applied at all.
How has this been tested?
Manual testing.
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
Bug Fixes
Tests