Added a button to frame player to copy filename #8989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8989 +/- ##
===========================================
+ Coverage 73.39% 73.40% +0.01%
===========================================
Files 415 416 +1
Lines 44192 44198 +6
Branches 3859 3860 +1
===========================================
+ Hits 32435 32445 +10
+ Misses 11757 11753 -4
|
bsekachev
reviewed
Jan 27, 2025
cvat-ui/src/components/annotation-page/top-bar/player-navigation.tsx
Outdated
Show resolved
Hide resolved
bsekachev
approved these changes
Jan 28, 2025
|
6 tasks
archibald1418
added a commit
that referenced
this pull request
Feb 13, 2025
…ame (#9081) This checks that the frame filename displayed in the annotation view UI is copied to clipboard correctly Regression test for #8989 ### How has this been tested? Use the existing Main task to trigger UI events that change clipboard contents. #### Prepartion ##### before the test suite - Create main task - Open main task job ##### before each test case - Add a spy on the window's clipboard (has to be new every case) _Note: Unlike mocks, spies call the real function to gain information on how this function was called_ ### Cases #### Case 1: Check that frame filename can be copied to clipboard - Scrape active filename - Press on button, confirm that both filenames are equal #### Case 2: Check clipboard after switching frames - Switch to next frame - Repeat actions from Case 1 ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) ### License - [ ] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. --------- Co-authored-by: Oleg Valiulin <oleg.valiulin@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Added a simple button to quickly copy frame name.
Resolved #7237
How has this been tested?
Checklist
developbranch[ ] I have added tests to cover my changesLicense
Feel free to contact the maintainers if that's a concern.