-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for interpolation issues after deleting keyframes #9031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` deletion instead of before
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9031 +/- ##
===========================================
+ Coverage 73.42% 73.74% +0.32%
===========================================
Files 419 428 +9
Lines 44351 44501 +150
Branches 3875 3875
===========================================
+ Hits 32563 32816 +253
+ Misses 11788 11685 -103
|
bsekachev
reviewed
Feb 3, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
bsekachev
reviewed
Feb 3, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
bsekachev
reviewed
Feb 3, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
bsekachev
reviewed
Feb 3, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
bsekachev
reviewed
Feb 3, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
bsekachev
reviewed
Feb 4, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
Please, update the code first. Then, resolve corresponding comments. |
bsekachev
reviewed
Feb 5, 2025
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
tests/cypress/e2e/issues_prs2/issue_8952_interpolation_impossible.js
Outdated
Show resolved
Hide resolved
bsekachev
approved these changes
Feb 5, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression test for 2 bugs that were fixed in #8951 and #8952
The fix dealt with incorrect frame interpolation when deleting keyframes
Also, opening the task afterwards could crash with application error
How has this been tested?
This consists of two test cases reflecting two different bugs +
before()
andbeforeEach()
hooks which unifies conditions before both cases.Preparation
Before all tests:
(NB:
headless..
commands only work withmounted_file_share
which being regularly cleared in Helm CI)jobID
into a variableJobsApI
to create a rectangle track with 3 keyframes: 0, 2 and 4. After this, the rectangle moves clockwise along the image's perimeter (topLeft -> topCenter -> topRight -> centerRight -> bottomRight)Before each test
PATCH
request to senddeleted_frames: []
to/data/meta
. This recovers frame deletions that were done under test. Wait for responseGET
to/data/meta
which will load the created rectangle track onto the#cvat_canvas_background
.Case 1
This checks that the job can be opened without any crashes or error notification messages after deleting keyframes and saving the job. Interpolation is terminated and the tracked rectangle should not exist in the DOM
Case 2
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.