Add Project Connection setup for Vault OAuth provider. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial commit adding support for managing Hashicorp Vault OAuthProvider connections. N.B: This requires the `HashiCorp Vault Support` plugin is installed within TeamCity
fatmcgav
changed the title
added 4 commits
October 30, 2020 10:34
Move a lot of the `project_feature_versioned_settings` tests into a dedicated test file. Expand `project_feature_test` to create test multiple features, etc.
This adds a new `Locator` function to generate a Type and Provider locator query string.
This commit adds a new `GetByTypeAndProvider` function to the `ProjectFeatureService`. This function can be used to find TeamCity Project features based on their `type` and `providerType` values. Useful when there are multiple featurs of a single `type`, such as when multiple `OAuthProvider` features are enabled on a given project.
|
@cvbarros I think this one is ready for a review now. Let me know if can provide any more info etc :) |
fatmcgav
changed the title
2 tasks
cvbarros
reviewed
Nov 18, 2020
There was a problem hiding this comment.
This is 💯 , super complete implementation - Really really helpful!
My only suggestion would be to extract the Vault Connection-specific implementation and types to its own files and test cases, making it easier to extend with new project connections (as there are endless possibilities with plugins here).
| @@ -0,0 +1,161 @@ | |||
| package teamcity | |||
There was a problem hiding this comment.
May I suggest we break the feature_connection from the specific Vault types here?
Perhaps a project_connection_vault_oauth.go would be more suitable.
| Options: ConnectionProviderVaultOptions{}, | ||
| } | ||
|
|
||
| // stringProperties := []string{"displayName", "endpoint", "namespace", "role-id", "url", "vault-namespace"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial commit adding support for managing Hashicorp
Vault OAuthProvider connections.
N.B: This requires the
HashiCorp Vault Supportplugin is installedwithin TeamCity
Fixes #90