Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for TeamCity Role Assignments for User Groups #86

Closed
wants to merge 2 commits into from
Closed

Added support for TeamCity Role Assignments for User Groups #86

wants to merge 2 commits into from

Conversation

eli-guidewire
Copy link
Contributor

  • created a TeamCity resource (resource_group_role_assignment) which can assign to groups and unassign roles from groups
  • added tests for the group role assignment resource
  • updated the TeamCity main-config.xml to enable the per project permissions

This pull request relies on the pull request from the go-teamcity project:
cvbarros/go-teamcity#86

@eli-guidewire
Copy link
Contributor Author

Note that CI tests are going to fail until the reference to go-teamcity is updated.

@sundarok
Copy link

sundarok commented Jun 9, 2020

Hi @cvbarros Can you please review and merge this PR?

@cvbarros cvbarros mentioned this pull request Jun 11, 2020
Merged
@cvbarros cvbarros added this to the 1.2 milestone Jun 11, 2020
@cvbarros
Copy link
Owner

cvbarros commented Jun 11, 2020 •
edited
Loading

Hi @eli-guidewire , would you be so kind to please rebase onto current master after #89 is merged. That way we can have the CI checks - once done we'll get this merged and released asap.
Thanks!

Edit: Sorry, I've noticed that this PR is creating new resources - it's not blocking, but would be 💯 if we could also add some documentation about them.

cvbarros
cvbarros requested changes Jun 11, 2020
View reviewed changes
integration_tests/start_teamcity.sh Outdated

bsdtar -xzf teamcity_data.tar.gz
# using tar which is readily available whereas bsdtar is not even available on some linux distros
tar -xzf teamcity_data.tar.gz
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented here: #88 (comment)

@justinto-guidewire
Copy link
Contributor

Hi @cvbarros, sorry we missed your latest comment in the PR, where would you like us to add documentation for this new resource?

@justinto-guidewire
Copy link
Contributor

We'll have to do some clean up on this branch first and maybe create another PR if necessary

@justinto-guidewire justinto-guidewire mentioned this pull request Jul 2, 2020
Merged
@justinto-guidewire
Copy link
Contributor

I've forked another repo and recreated this PR, see: #90

Feel free to close this PR as I don't see an option for me to close myself...

@cvbarros cvbarros closed this Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvbarros cvbarros cvbarros requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@eli-guidewire @sundarok @cvbarros @justinto-guidewire