Correct bug "ERROR: Can't extend QueryBuilder with existing method ('cache')" #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cache')"
Corrected bug where passing in an existing instance of Knex connection results in failure to extend QueryBuilder with cache method.
`ERROR: Can't extend QueryBuilder with existing method ('cache')`
Fixes cvburgess#81 and I think cvburgess#83 but I would like @marvin-kolja thoughts on that.
See explanation here cvburgess#81 (comment)
daniel-keller
changed the title
|
Hey @daniel-keller. Sorry for the late response. I haven't tested your new approach, but it seems reasonable. Regarding #83, this PR fixes the approach I have chosen in my example there. However, in my issue I'm rather talking about the problem that results from creating the datasource only once and reusing it over and over again - without your PR merged I don't see a reason to continue using this library since it doesn't work as I need it to. @cvburgess Would love to see some feedback from your side :) |
|
@daniel-keller thank you for the contribution! I have released 2.1.0 with this change 🙏} cc @marvin-kolja if this is still helpful to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected bug where passing in an existing instance of Knex connection results in failure to extend QueryBuilder with cache method.
ERROR: Can't extend QueryBuilder with existing method ('cache')Fixes #81 and I think #83 but I would like @marvin-kolja thoughts on that. See explanation here #81 (comment)