Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonization of some endpoints #70

Merged
merged 7 commits into from
Nov 26, 2024
Merged

Conversation

cedricbonhomme
Copy link
Member

The endpoints redis_up, dbInfo, and configInfo are now under /api/system.

All API endpoints related to vulnerabilities (CVE, PySec, GHSA, etc.) are under /api/vulnerability including the endpoints last and browse.

The interoperability with previous endpoints has been kept and the documentation is mentioning the change.
https://vulnerability.circl.lu/doc

Copy link
Collaborator

@Rafiot Rafiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

user = self.client.create_user(name='test_Name', login='test_Login',
organisation='test Organization', email='test@testorg.local')
user = self.client.create_user(name='test Name', login='alan',
organisation='test Organization', email='test@testorg.lu')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very much a detail, but I avoid using any TLD other than .local because at some point, a system will be configured to send emails and this is going to be a problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example.com ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer .local: https://en.wikipedia.org/wiki/.local

example.com doesn't have a MX record, but it could one day.

Copy link
Member Author

@cedricbonhomme cedricbonhomme Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw your comment here. Anyway, it's fine now ;-)

@Rafiot Rafiot merged commit e4a8994 into cve-search:main Nov 26, 2024
4 of 8 checks passed
@cedricbonhomme cedricbonhomme deleted the api-changes branch November 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants