-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonization of some endpoints #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
tests/test_web.py
Outdated
user = self.client.create_user(name='test_Name', login='test_Login', | ||
organisation='test Organization', email='test@testorg.local') | ||
user = self.client.create_user(name='test Name', login='alan', | ||
organisation='test Organization', email='test@testorg.lu') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very much a detail, but I avoid using any TLD other than .local
because at some point, a system will be configured to send emails and this is going to be a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example.com ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer .local
: https://en.wikipedia.org/wiki/.local
example.com
doesn't have a MX record, but it could one day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just saw your comment here. Anyway, it's fine now ;-)
The endpoints
redis_up
,dbInfo
, andconfigInfo
are now under/api/system
.All API endpoints related to vulnerabilities (CVE, PySec, GHSA, etc.) are under
/api/vulnerability
including the endpointslast
andbrowse
.The interoperability with previous endpoints has been kept and the documentation is mentioning the change.
https://vulnerability.circl.lu/doc