Fix cookbook version sorting #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when sorting cast and compare version objects rather than assuming its a string. Signed-off-by: Ben Abrams <me@benabrams.it>
…ss if they are in use. While this might sound like a bad idea it is actually helpful in situations where you have outdated inventory. Signed-off-by: Ben Abrams <me@benabrams.it>
Signed-off-by: Ben Abrams <me@benabrams.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when sorting cast and compare version objects rather than assuming its a string.
fixes #6
Also added
--ignored-usedflag to return the list of cookbooks regardless if they are in use.While this might sound like a bad idea in my org we unfortunately have stale inventory and therefore old versions of cookbooks will never get deleted because they were never removed from the chef server. While doing some testing/validation that the sorting worked as intended I noticed some odd behavior and traced it down to this and validated that the output matches what I see with the plugin I currently maintain when using the new flag.
Signed-off-by: Ben Abrams me@benabrams.it