Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathlib.Path.glob does not follow symlinks #283

Closed
Keunmo opened this issue Jul 5, 2023 · 0 comments · Fixed by #284
Closed

pathlib.Path.glob does not follow symlinks #283

Keunmo opened this issue Jul 5, 2023 · 0 comments · Fixed by #284

Comments

@Keunmo
Copy link
Contributor

Keunmo commented Jul 5, 2023

It is same issue as introduced in cpython.

Shortly, if there are symlinks under Path(root), Path(root).glob('**/*') does not catch all pathnames from symlink.

So it makes error if user use symlink at datasets and do extract_features.py

Solution is simple. Just replace Path(root).glob('**/'+g) with Path(root).rglob('*/'+g).

I'll open pull request for this issue soon.

Keunmo added a commit to Keunmo/Hierarchical-Localization that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant