Allow refining principal point during bundle adjustment #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current interface does not allow optimizing the principal point during bundle adjustment, since the call to
pycolmap.incremental_mappingis done using this overload instead of this one, andba_refine_principal_pointis set to False by default in COLMAP. As a consequence, the principal point remains fixed to its initial estimate, i.e., the center of the image.This change allows optionally refining the principal point, which in my setup produced much better pose estimates. Opening this PR in case you think this could be desirable for other people.