Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in dense match refinement #243

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Bug fix in dense match refinement #243

merged 1 commit into from
Oct 17, 2022

Conversation

Phil26AT
Copy link
Collaborator

  • Fixes a bug in assign_keypoints that occured when cell_size=None
  • Unifies pairs format with LoFTR keypoint refinement: usually the query is the first name of each line in hlocs pairs-*.txt, and the reference the second. We thus assume now that dense matching models refine keypoints in the left image (image0).

@Phil26AT Phil26AT requested a review from sarlinpe October 12, 2022 12:55
@sarlinpe sarlinpe merged commit 23b0c31 into master Oct 17, 2022
ginofft added a commit to ginofft/Hierarchical-Localization that referenced this pull request Oct 27, 2022
Fix dense assignment without aggregation (cvg#243)
@sarlinpe sarlinpe deleted the fix-dense-matching branch December 13, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants