Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#71

Merged
merged 1 commit into from
Jun 26, 2021
Merged

#71

merged 1 commit into from
Jun 26, 2021

Conversation

mhumenbe
Copy link
Contributor

When using image lists for feature extraction, 'path' in getitem is no instance of Path (it is a str) and it will crash when trying to call path.as_posix().

I also added a warning if there are no db images retrieved (for some reason) for a query image. Such queries will be skipped.

…ash at path.as_posix()

skip query images for which, for some reason, no images were retrieved
@sarlinpe
Copy link
Member

Thanks for the PR! I will push some fixes to cleanup extract_features.

@sarlinpe sarlinpe merged commit bcf2c47 into cvg:dev Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants