PyQt5 #154
Open
PyQt5 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code caused the following error:
Traceback (most recent call last):
File "...\lib\site-packages\sloth\gui\labeltool.py", line 132, in onCurrentImageChanged
if img == None:
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
Fixed comparison to None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates sloth from PyQt4 to PyQt5
It looks like Anaconda python distro can't have both PyQt4 and PyQt5 installed in parallel (at least I didn't find a way to coerce it into installing both side by side), and the distro itself depends on PyQt5. So, if I want any of the data scientists to be able to run sloth, I need this :)