Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error with full_info and POT #21

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Conversation

ilapros
Copy link
Collaborator

@ilapros ilapros commented Mar 15, 2020

When asking full_info =TRUE on POT with no missing/non-valid records I got Error in strsplit(rejected_periods, "[/]") : non-character argument. Fixed by creating an empty periods vector. Also added a test for that

When asking full_info =TRUE on POT with no missing/non-valid records I got Error in strsplit(rejected_periods, "[/]") : non-character argument. Fixed by creating an empty periods vector. Also added a test for that
@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #21 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   73.11%   73.37%   +0.26%     
==========================================
  Files          11       11              
  Lines         305      308       +3     
==========================================
+ Hits          223      226       +3     
  Misses         82       82
Impacted Files Coverage Δ
R/internals.R 93.1% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8eda3...1fe9501. Read the comment docs.

@cvitolo cvitolo merged commit 0009172 into cvitolo:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants