Adding Helm Chart #14
Conversation
| @@ -0,0 +1,5 @@ | |||
| apiVersion: v1 | |||
| appVersion: "1.0.1" | |||
There was a problem hiding this comment.
The latest tag/release is 1.1.0, maybe we set that here.
| appVersion: "1.0.1" | ||
| description: A Helm chart to deploy the CVMFS-CSI Plugin | ||
| name: cvmfs-csi | ||
| version: 1.3.2 |
There was a problem hiding this comment.
Should we start with something like 0.1.0?
| @@ -0,0 +1,57 @@ | |||
| kind: Service | |||
There was a problem hiding this comment.
We don't use (need) the cvmfs attacher, not sure if you rely on it - in principle for this CSI driver it shouldn't be needed. In case you do need it for some reason, could you make it optional with a 'enabled' flag in the values?
| @@ -0,0 +1,53 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
Same as below, dropping or making this chart optional.
| csiProvisioner: | ||
| image: quay.io/k8scsi/csi-provisioner:v1.0.1 | ||
| args: | ||
| - "--provisioner=csi-cvmfsplugin" |
There was a problem hiding this comment.
We've updated the provisioner name to match the driver: cvmfs.csi.cern.ch. Not sure if you're relying on this being csi-cvmfsplugin, if yes could we make this configurable? We would need to update it in all the templates as well.
Here's the internal validation test we're using at CERN:
https://github.com/cernops/cvmfs-csi/blob/64110dd66c5f1825b33c35e67c444b5c6e957c5f/test/01-validation-cern.yaml#L5
| - "--nodeid=$(NODE_ID)" | ||
| - "--endpoint=$(CSI_ENDPOINT)" | ||
| - "--v=5" | ||
| - "--drivername=csi-cvmfsplugin" |
There was a problem hiding this comment.
This was changed to cvmfs.csi.cern.ch in most places, as below:
https://github.com/cernops/cvmfs-csi/blob/master/deployments/kubernetes/csi-cvmfsplugin.yaml#L55
|
Hi @almahmoud . I've done a first try. A few ocmments in the review, but it looks really good thanks! |
| # the cache PVs are defined manually for all pods of the DaemonSet. | ||
| # If local cache is enabled, alien cache must be disabled. | ||
| localCache: | ||
| enabled: false |
There was a problem hiding this comment.
Should we invert these defaults? That is, using localCache instead of alienCache? As far as i'm aware most sites run a local cache?
|
@almahmoud here are a couple changes i've done: Let me know, i'll probably merge this soon with the above. |
|
All the changes look good to me, sorry for not getting back to this earlier... it’s been a rough few months (our PI passed on top of everything happening in the world)... |
|
Thanks for the contribution, hope all is well. |
A generic version of the chart used by the Galaxy Project: https://github.com/CloudVE/galaxy-cvmfs-csi-helm/
Replaces #3