feat: use GitHub Actions cache to persist the CernVM-FS cache #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocaisa
reviewed
May 22, 2025
| - uses: actions/cache@v4 | ||
| if: ${{ inputs.actions_cache == 'true' }} | ||
| with: | ||
| key: cvmfs-cache-${{ steps.lsb-release.outputs.id-release }}-${{ steps.lsb-release.outputs.arch }}-${{ hashFiles('action.yml') }} |
There was a problem hiding this comment.
Suggested change
| key: cvmfs-cache-${{ steps.lsb-release.outputs.id-release }}-${{ steps.lsb-release.outputs.arch }}-${{ hashFiles('action.yml') }} | |
| key: cvmfs-cache-${{ steps.lsb-release.outputs.id-release }}-${{ steps.lsb-release.outputs.arch }} |
as seen in #40, using ${{ hashFiles('action.yml') }} as part of the key is not reliable as the file being hashed as very unlikely to appear in other repositories and causes caches to always miss.
vvolkl
reviewed
May 22, 2025
| with: | ||
| key: cvmfs-cache-${{ steps.lsb-release.outputs.id-release }}-${{ steps.lsb-release.outputs.arch }}-${{ hashFiles('action.yml') }} | ||
| path: | | ||
| ${{ inputs.cvmfs_cache_base }} |
There was a problem hiding this comment.
Suggested change
| ${{ inputs.cvmfs_cache_base }} | |
| ${{ inputs.cvmfs_cache_base }} |
One further issue may be that the cache directory is used for a number of locks and marker files that we may not want to cache. I think in the end you only want to keep the actual data files in the hash directories ./00/ ... ./ff and maybe the ./cachedb file.
I'll test a few configurations to see what works best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.