Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher icon #25

Closed
JonnyTech opened this issue May 2, 2020 · 8 comments
Closed

Launcher icon #25

JonnyTech opened this issue May 2, 2020 · 8 comments

Comments

@JonnyTech
Copy link

When the option to Hide app icon from launcher is enabled, the icon remains visible in the launcher and clicking on it pops up a toast message stating App uninstalled..

@cvzi
Copy link
Owner

cvzi commented May 3, 2020

Thanks for the report. Which launcher do you use (or phone model, if you're using the standard launcher)?
I just tested a few on several emulators and it still seems to work fine for me. It looks like some launchers (e.g. Nova) require several minutes (or a reboot) to update the icons.

@JonnyTech
Copy link
Author

Using OpenLauncher on AOSP 10 GSI. Just tried with built-in QuickStep launcher and the icon remains too. Clicking on it when set to hidden takes me to the settings App Info page for the app. No change after a reboot. Would you like me to try something else?

@cvzi
Copy link
Owner

cvzi commented May 3, 2020

Looks like manually hiding an icon is no longer supported on Android 10 😪
It's only possible if the app is already "hidden" on install or does not require any permissions (android reference)

I guess I'll then remove the option on Android 10

@JonnyTech
Copy link
Author

Another app was able to hide its icon and works on Android 10 (Suntimes). Maybe the related commit may help.

@cvzi
Copy link
Owner

cvzi commented May 3, 2020

Thanks, at first glance that commit looks to be the same code as I am using. I'll try around on an emulator with Android 10 when I have some more time.
It might be that we can still hide icons but only if there are multiple icons for one app

@cvzi
Copy link
Owner

cvzi commented May 4, 2020

For now I removed the setting for Android 10.

It seems like removing all icons of an app is only possible if the app uses no permissions.
Otherwise at least one icon remains visible, which is a dummy icon that opens the "app setting screen" where you can uninstall the app.

I guess this is a security feature, so you don't forget about an app that has requested sensitive permissions.

According to the Android reference it should also be possible to completely remove the launcher icon. I wasn't able to make it work, but if I manage to do that, I could make a "light version" of the app without any icon.

@JonnyTech
Copy link
Author

Fair comprompise - if nothing else, you squashed a bug. Thanks for the quick response, I shall leave this issue for you to close when you feel ready to.

@cvzi
Copy link
Owner

cvzi commented Sep 12, 2021

I am closing this as there is no indication that it will be possible to hide it again

Also for reference: I had reported the discrepancy in the documentation to Google but it has not been resolved: https://issuetracker.google.com/issues/155685106

@cvzi cvzi closed this as completed Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants