Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect image shown in recents menu #185

Closed
Einlion opened this issue May 1, 2024 · 14 comments
Closed

Incorrect image shown in recents menu #185

Einlion opened this issue May 1, 2024 · 14 comments
Labels
bug Something isn't working

Comments

@Einlion
Copy link

Einlion commented May 1, 2024

Screenshot_20240501-203056

The wallpaper shown in recents screen is not the wallpaper being picked, instead its a default icon.
I am on Android 14 but this was present in 13 as well. I have tested applying other live wallpapers and they seem to work fine.

Thanks.

@cvzi cvzi added the bug Something isn't working label May 12, 2024
@cvzi
Copy link
Owner

cvzi commented May 12, 2024

I can't solve this anytime soon.

I don't have Android 13/14 on my phone. I tried to test it with Android emulator, but the Google Pixel that are available on the emulator don't show the wallpaper in the recent screens at all, they only show a solid color.

@cvzi
Copy link
Owner

cvzi commented May 16, 2024

Other live wallpapers are shown in the recent menu in a blurred way or normal?

And what phone do you have?

@Einlion
Copy link
Author

Einlion commented May 16, 2024

They are shown in a blurred way.
I have moto edge 30 ultra, Android 14
There's a chance this might be a moto launcher gotcha but I don't have a good idea on how live wallpapers work.

@cvzi
Copy link
Owner

cvzi commented May 17, 2024

Thanks. I'll take another look.

It is probably the Moto launcher that offers this feature of showing the wallpaper. I know the Moto Launcher customized the "recents screen" on Android 10 and this couldn't even be disabled, because it's part of the system. Even if you installed a third-party launcher, the Moto launcher was still handling the "recents screen" itself. Likely the same applies to Android 14.

@Einlion
Copy link
Author

Einlion commented Jul 1, 2024

Hi, I believe the launcher is somehow using https://github.com/cvzi/darkmodewallpaper/blob/main/app/src/main/res/xml/wallpaper_info.xml#L25 as bg, tho i have no way to test and when im trying to generate local debug build it keeps failing.

@cvzi
Copy link
Owner

cvzi commented Jul 1, 2024

I have updated the repository, now the apk files are created in the Github actions.
For example this is the last run: https://github.com/cvzi/darkmodewallpaper/actions/runs/9748487167
At the bottom you can download the apk files.

I believe if you enable Github actions in your cloned repository here and update the Github action file to the version that I just created gradleCI.yml,
then your repository should also generate the apk files, if you push a change.

See Einlion/live-wall-test@721eb0f#r143729428 for why your build is failing.

@Einlion
Copy link
Author

Einlion commented Jul 1, 2024

Thanks for the quick response! I tried the new version after those changes, looks file it's fixed now, I get a transparentish background as expected. I do not have full idea as to what that parameter actually is for and if changing it to transparent would cause any issue in hindsight.

@cvzi
Copy link
Owner

cvzi commented Jul 2, 2024

Any app can just request this thumbnail to use it, but the only use-case I know is the wallpaper selector. The thumbnail usually appears in the list of installed live wallpapers in the wallpaper selector.
Could be bug that moto launcher uses the thumbnail. Or maybe this app doesn't correctly deliver the actual wallpaper and the moto launcher uses the thumbnail as a "fallback" solution.

I wonder if it also works if you just remove the thumbnail.
Could you test it without it, like this:

<wallpaper xmlns:android="http://schemas.android.com/apk/res/android"
    android:description="@string/wallpaper_description"
    android:settingsActivity="com.github.cvzi.darkmodewallpaper.activity.MainActivity"
    android:showMetadataInPreview="true"
    android:supportsMultipleDisplays="true" />

Maybe also change the application id again to prevent any caching of the thumbnail

Edit:

I've checked a few other open source live wallpapers, and they all seem to use this thumbnail the same way as I did. So at least that seems to be correct.

Removing the thumbnail completely vs. a transparent thumbnail seems to make a difference for some phone manufacturers:
If there is no thumbnail, the wallpaper selector will show the app icon instead (which is the same icon as the thumbnail in our case).
However this is not true for all phones, the Pixel wallpaper selector doesn't show the app icon, it shows a blank space i.e. there is no difference between no-thumbnail and transparent-thumbnail.

@cvzi
Copy link
Owner

cvzi commented Aug 12, 2024

@eddieofny
I have create two test apk files for you.

This file has no thumbnail: https://github.com/cvzi/darkmodewallpaper/releases/download/v1.7.0/no-thumbnail.apk

And this file has a transparent thumbnail: https://github.com/cvzi/darkmodewallpaper/releases/download/v1.7.0/transparent-thumbnail.apk

I would appreciate if you could test both of them and see if it solves the problem or if there is any difference. Thanks!

@eddieofny
Copy link

@cvzi Sorry this took me some time. I tested both APKs and they both work perfectly. Thanks!

cvzi added a commit that referenced this issue Aug 16, 2024
@cvzi
Copy link
Owner

cvzi commented Aug 16, 2024

@eddieofny Thank you! I will include the solution in the normal version.

@Einlion
Copy link
Author

Einlion commented Aug 17, 2024

I tried these as well, with no banner, it works fine but with the transparent one, my wallpaper app crashes and i cant apply new wallpaper the normal way, though there are workarounds for that.

@cvzi
Copy link
Owner

cvzi commented Aug 17, 2024

Thanks! I did include the "no thumbnail" solution in the normal version 😀

It will take a few days until F-Droid builds and publishes the new version.

@cvzi
Copy link
Owner

cvzi commented Aug 22, 2024

The new version 1.7.1 is now on F-Droid and in the Github releases (Google Play store will take a few hours or days). I would suggest to both of you to install that version again (you will lose the app settings unfortunately), so that you automatically get updates from F-Droid or Play Store .

@cvzi cvzi closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants