Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Pin jsonschema below 4.18 (not 4.1.8) #238

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

EliahKagan
Copy link
Contributor

Closes #237

This fixes the upper bound for the jsonschema dependency, so any version below 4.18 is allowed.

As a matter of style, I was unsure if I should specify the upper bound as 4.18 or 4.18.0, but the lower bound is specified in major.minor style, so I went with 4.18.

@cwacek
Copy link
Owner

cwacek commented Aug 6, 2023

Oof. You're totally right @EliahKagan. Thanks for the PR - will merge shortly assuming tests pass

@cwacek cwacek merged commit 7d1f774 into cwacek:master Aug 7, 2023
7 checks passed
@EliahKagan EliahKagan deleted the jsonschema-pinning branch August 7, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.3 pins jsonschema <4.1.8, but it should be <4.18
2 participants