cleanup: Unset test_regression_114 executable bit #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/test_regression_114.py, and no other test modules, had its executable bit set. Since there are no indications that this was meant to be treated as an executable file on Unix-like systems, running it successfully as a script would not run the test, and executing it would typically cause a POSIX-style shell rather than a Python interpreter to run it (there is no "#!"), that appears unintentional. This unsets that executable bit so that git tracks all the test modules with the same file mode values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/test_regression_114.py, and no other test modules, had its executable bit set. There are no indications that this was meant to be treated as an executable file on Unix-like systems, running it successfully as a script would not run the test, and executing it would typically cause a POSIX-style shell rather than a Python interpreter to run it (there is no#!), so that appears unintentional.This unsets that executable bit on that one file that had it, so that git tracks all the test modules with the same file mode values.
The benefit of this change is minor, but goes slightly beyond consistency for its own sake, because it is useful to be able to run
ls -lto get a sense of what files are meant to be run as scripts.In some views and with UI settings, GitHub wrongly shows the affected file as empty in the "Files changed" tab of this PR. However, it is nonempty, and this PR changes only its mode, not its contents.