Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate entries after failed patch. #143

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

LionsAd
Copy link
Contributor

@LionsAd LionsAd commented Jul 14, 2017

This supersedes #142, though installed.json needs to be manually cleaned to get back to a good state.

Closes: #123

@LionsAd
Copy link
Contributor Author

LionsAd commented Jul 17, 2017

@cweagans ^^ (this patch is really important!)

@cweagans cweagans merged commit 6bd6ecd into cweagans:master Jul 17, 2017
@cweagans
Copy link
Owner

Thanks for fixing this! Sorry for the delay. Was AFK.

@DrColossos
Copy link

DrColossos commented Aug 9, 2017

I still have the same issue with the patch applied here and described in #142. I replaced all array_marge_recursive() calls with $this->arrayMergeRecursiveDistinct() and all patches apply cleanly every time. It seems like having a distinct structure is the better intention of the code anyways, so we should reuse it #149

@ericchenshine
Copy link

The PR 149 fixes the issue. Thanks

@DrColossos
Copy link

I updated the pull request to the latest master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants