Increase post install/update handler priority to support other plugins #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes other plugins (with priority=0) to run after that patches have been applied.
|
Hi @cweagans, |
|
I don't have an immediate objection to this, but at a minimum, this needs a comment about why the weight is increased so that it doesn't get blown away later. |
|
HI @cweagans, you mean a comment in the code? |
|
Yes. Just right above the lines where the weight is increased. Something to the effect of "This is a higher weight for compatibility with [plugin]" |
|
@cweagans Ok I'll do it but reopen this pull request please because I'll update the |
|
Ah, sorry. Was closing some others. Closed this by mistake. |
|
@cweagans done! |
|
Thanks! |
|
Thank you to you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many other Composer's plugins that perform install operation on packages after they have been installed. Many times this operation involves coping packages files elsewhere (look at https://github.com/AydinHassan/magento-core-composer-installer for an example). In such situation it's useful to have patches applied BEFORE the install/copy operation. So, this PR increase the post install/update event handler's priority so other plugins (with priority=0) to run after that patches have been applied.