Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for Resolvers\PatchesFile #381

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Increase test coverage for Resolvers\PatchesFile #381

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6adbaba
Name distinct tests
fredden Sep 22, 2021
a506737
Abstract common elements from tests
fredden Sep 22, 2021
73c9fae
Avoid try/catch in test for exceptions
fredden Sep 22, 2021
e1454fd
Increase test coverage
fredden Sep 22, 2021
a56adc8
Merge remote-tracking branch 'upstream/master' into test-coverage/res…
fredden Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 66 additions & 42 deletions tests/unit/PatchesFileResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,51 +14,75 @@

class PatchesFileResolverTest extends Unit
{
public function testResolve()
public function setUp(): void
{
$composer = new Composer();
$this->package = new RootPackage('test/package', '1.0.0.0', '1.0.0');
$this->composer = new Composer();
$this->composer->setPackage($this->package);
$this->io = new NullIO();
$this->event = Stub::make(PackageEvent::class, []);
$this->collection = new PatchCollection();
$this->resolver = new PatchesFile($this->composer, $this->io);
}

// Happy path.
$package = new RootPackage('test/package', '1.0.0.0', '1.0.0');
$package->setExtra([
public function testHappyPath()
{
$this->package->setExtra([
'patches-file' => __DIR__ . '/../_data/dummyPatches.json',
]);
$composer->setPackage($package);
$io = new NullIO();
$event = Stub::make(PackageEvent::class, []);

$collection = new PatchCollection();
$resolver = new PatchesFile($composer, $io);
$resolver->resolve($collection, $event);
$this->assertCount(2, $collection->getPatchesForPackage('test/package'));
$this->assertCount(2, $collection->getPatchesForPackage('test/package2'));

// Empty patches.
try {
$package = new RootPackage('test/package', '1.0.0.0', '1.0.0');
$package->setExtra([
'patches-file' => __DIR__ . '/../_data/dummyPatchesEmpty.json',
]);
$composer->setPackage($package);
$collection = new PatchCollection();
$resolver = new PatchesFile($composer, $io);
$resolver->resolve($collection, $event);
} catch (InvalidArgumentException $e) {
$this->assertEquals('No patches found.', $e->getMessage());
}

// Invalid JSON.
try {
$package = new RootPackage('test/package', '1.0.0.0', '1.0.0');
$package->setExtra([
'patches-file' => __DIR__ . '/../_data/dummyPatchesInvalid.json',
]);
$composer->setPackage($package);
$collection = new PatchCollection();
$resolver = new PatchesFile($composer, $io);
$resolver->resolve($collection, $event);
} catch (InvalidArgumentException $e) {
$this->assertEquals('Syntax error', $e->getMessage());
}

$this->resolver->resolve($this->collection, $this->event);
$this->assertCount(2, $this->collection->getPatchesForPackage('test/package'));
$this->assertCount(2, $this->collection->getPatchesForPackage('test/package2'));
}

public function testEmptyPatches()
{
$this->package->setExtra([
'patches-file' => __DIR__ . '/../_data/dummyPatchesEmpty.json',
]);

$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('No patches found.');

$this->resolver->resolve($this->collection, $this->event);
}

public function testInvalidJSON()
{
$this->package->setExtra([
'patches-file' => __DIR__ . '/../_data/dummyPatchesInvalid.json',
]);

$this->expectException(\InvalidArgumentException::class);
$this->expectExceptionMessage('Syntax error');

$this->resolver->resolve($this->collection, $this->event);
}

public function testPatchesFileNotFound()
{
$this->package->setExtra([
'patches-file' => __DIR__ . '/../_data/noSuchFile.json',
]);

// Check that the collection is emtpy to start with
$this->assertSame(['patches' => null], $this->collection->jsonSerialize());

// This error is handled silently.
$this->resolver->resolve($this->collection, $this->event);

$this->assertSame(['patches' => null], $this->collection->jsonSerialize());
}

public function testNoPatchesFile()
{
// Check that the collection is emtpy to start with
$this->assertSame(['patches' => null], $this->collection->jsonSerialize());

// This is not an error. No changes should be made to the collection.
$this->resolver->resolve($this->collection, $this->event);

$this->assertSame(['patches' => null], $this->collection->jsonSerialize());
}
}