Introduce "composer-exit-on-patch-failure" config option. #46
Conversation
|
This will cause |
|
@cweagans, I can't get what you mean... For me |
| @@ -269,10 +269,12 @@ public function postInstall(PackageEvent $event) { | |||
| $extra['patches_applied'][$description] = $url; | |||
| } | |||
| catch (\Exception $e) { | |||
| $this->io->write(' <error>Could not apply patch! Skipping.</error>'); | |||
| if (getenv('COMPOSER_EXIT_ON_PATCH_FAILURE')) { | |||
There was a problem hiding this comment.
Removing support for this constant breaks backwards compatibility.
There was a problem hiding this comment.
👍 ^^ what @bartfeenstra said. Thanks for catching that.
|
According to the schema, that should fail. I was going to open a PR against Composer to relax the schema for |
NEWSITE-58
|
I also restored the |
|
Would the
|
NEWSITE-58
|
@cweagans, thanks for the explanation. I did not know that |
|
@Leksat I would love to be able to use this feature. Would you be able to resolve the merge conflict with this PR so that it can be merged in? |
|
Hey @erikhansen, I updated this PR to resolve the conflict. Please test and provide feedback. Thanks in advance! |
|
@cweagans Any update on this getting included in the next release? Can we expect it in your 2.0 update? |
|
Sorry for the delay, folks. |
#40