Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to use external parameters and custom templates #90

Merged
merged 13 commits into from
May 20, 2019
Merged

Added ability to use external parameters and custom templates #90

merged 13 commits into from
May 20, 2019

Conversation

frenzywang
Copy link
Contributor

@frenzywang frenzywang commented Feb 25, 2019 •
edited by cweill
Loading

This diff is designed so that gotests can be called by other tools using a custom template to generate data other than the test function. Fixes #96.

Please help to review, thank you.

@coveralls
Copy link

coveralls commented Feb 27, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 96.376% when pulling 776ffe0 on a1305315624:master into afa0a37 on cweill:develop.

@cweill
Copy link
Owner

cweill commented Mar 1, 2019

@a1305315624, I'll try to have a look this weekend.

@cweill cweill changed the base branch from master to develop April 7, 2019 19:34
cweill
cweill reviewed Apr 7, 2019
View reviewed changes
Copy link
Owner

@cweill cweill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a1305315624: This mostly looks good to merge. Please see my comments.

gotests/main.go Outdated Show resolved Hide resolved
gotests.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gotests/main.go Outdated Show resolved Hide resolved
gotests/main.go Outdated Show resolved Hide resolved
internal/output/output.go Outdated Show resolved Hide resolved
internal/render/render.go Outdated Show resolved Hide resolved
testdata/goldens/use_external_paras_template_test.go Outdated Show resolved Hide resolved
gotests_test.go Show resolved Hide resolved
@frenzywang
Copy link
Contributor Author

I'll fix it at night

cweill
cweill requested changes Apr 26, 2019
View reviewed changes
Copy link
Owner

@cweill cweill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please resolve the comments, then we can merge.

internal/render/render.go Outdated Show resolved Hide resolved
gotests/main.go Show resolved Hide resolved
README.md Show resolved Hide resolved
@frenzywang
Copy link
Contributor Author

What do I need to do about merge code? that is my first pull request.

@cweill cweill merged commit f4738f4 into cweill:develop May 20, 2019
@cweill
Copy link
Owner

cweill commented May 20, 2019

Sorry about that. It's now merged to master.

cweill added a commit that referenced this pull request Jun 30, 2019
@cweill
Merge develop into master. (#103)
a871e1d 
* Fix TravisCI and add go1.11 and go1.12 support (#94)

* Fix function comments based on best practices from Effective Go (#89)

Signed-off-by: CodeLingo Bot <bot@codelingo.io>

* Added ability to use external parameters and custom templates (#90)
@cweill cweill mentioned this pull request Feb 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweill cweill cweill approved these changes

Assignees

@frenzywang frenzywang

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to pass external parameters to custom templates
3 participants
@frenzywang @coveralls @cweill