[Auditbeat] Disable packages metricset (elastic#9495)

The `packages` metricset is not yet ready. This disables the metricset's code, tests, fields, and docs until we have time to finish the work.
cwurm · Dec 15, 2018 · 381e779 · 381e779
1 parent f41a560
commit 381e779
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 10 deletions.
diff --git a/x-pack/auditbeat/auditbeat.reference.yml b/x-pack/auditbeat/auditbeat.reference.yml
@@ -112,7 +112,6 @@ auditbeat.modules:
 
   metricsets:
     - host
-    - packages
     - process
     - socket
     - user
@@ -124,8 +123,6 @@ auditbeat.modules:
   # detect any changes.
   user.detect_password_changes: true
 
-  report_changes: true
-
 
 #================================ General ======================================
 

diff --git a/x-pack/auditbeat/auditbeat.yml b/x-pack/auditbeat/auditbeat.yml
@@ -50,7 +50,6 @@ auditbeat.modules:
 
   metricsets:
     - host
-    - packages
     - process
     - socket
     - user
@@ -62,8 +61,6 @@ auditbeat.modules:
   # detect any changes.
   user.detect_password_changes: true
 
-  report_changes: true
-
 
 #==================== Elasticsearch template setting ==========================
 setup.template.settings:

diff --git a/x-pack/auditbeat/include/fields.go b/x-pack/auditbeat/include/fields.go
diff --git a/x-pack/auditbeat/module/system/_meta/config.yml.tmpl b/x-pack/auditbeat/module/system/_meta/config.yml.tmpl
@@ -5,7 +5,9 @@
 
   metricsets:
     - host
+    {{ if false -}}
     - packages
+    {{- end -}}
     - process
     {{ if eq .GOOS "linux" -}}
     - socket
@@ -20,8 +22,10 @@
   # detect any changes.
   user.detect_password_changes: true
   {{- end }}
-
+  {{- if false -}}
+  {{/* Only remaining use in packages, to be removed completely. */}}
   report_changes: true
+  {{- end -}}
 {{- end }}
 {{ if .Reference }}
 {{- end }}
diff --git a/...odule/system/packages/_meta/docs.asciidoc → ...tem/packages/_meta/docs.asciidoc.disabled b/...odule/system/packages/_meta/docs.asciidoc → ...tem/packages/_meta/docs.asciidoc.disabled
diff --git a/...t/module/system/packages/_meta/fields.yml → ...system/packages/_meta/fields.yml.disabled b/...t/module/system/packages/_meta/fields.yml → ...system/packages/_meta/fields.yml.disabled
diff --git a/x-pack/auditbeat/module/system/packages/packages.go b/x-pack/auditbeat/module/system/packages/packages.go
@@ -38,9 +38,9 @@ const (
 )
 
 func init() {
-	mb.Registry.MustAddMetricSet(moduleName, metricsetName, New,
+	/*mb.Registry.MustAddMetricSet(moduleName, metricsetName, New,
 		mb.DefaultMetricSet(),
-	)
+	)*/
 }
 
 // MetricSet collects data about the host.

diff --git a/x-pack/auditbeat/module/system/packages/packages_test.go b/x-pack/auditbeat/module/system/packages/packages_test.go
@@ -11,6 +11,8 @@ import (
 )
 
 func TestData(t *testing.T) {
+	t.Skip("Packages metricset is disabled")
+
 	f := mbtest.NewReportingMetricSetV2(t, getConfig())
 	err := mbtest.WriteEventsReporterV2(f, t, "")
 	if err != nil {

diff --git a/x-pack/auditbeat/tests/system/test_metricsets.py b/x-pack/auditbeat/tests/system/test_metricsets.py
@@ -29,6 +29,7 @@ def test_metricset_host(self):
             if "event.kind" not in str(e):
                 raise
 
+    @unittest.skip("Packages metricset is disabled")
     def test_metricset_packages(self):
         """
         packages metricset collects information about installed packages on a system.