Fix SchedulerTypeTime distance(to:) #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayoff
force-pushed
the
fix-SchedulerTimeType-distance
branch
from
f8914eb to
7781e8b
Compare
added 2 commits
February 2, 2021 18:01
These tests fail because CombineX's RunLoop.CX.SchedulerTimeType and OperationQueue.CX.SchedulerTimeType have incorrect implementations of the distance(to:) method.
mayoff
force-pushed
the
fix-SchedulerTimeType-distance
branch
from
7781e8b to
f97d175
Compare
|
I noticed how the other tests (in the same file, duh) were using |
|
Looks great! I just fixed falling tests irrelevant to this pr. Would you mind rebase and run checks again? Edit: There is no need to do so. I'll just merge it. Thank you! |
ddddxxx
approved these changes
Feb 3, 2021
|
@mayoff Hi, I noticed the CXShim solution is rather complicated for people new to CombineX. So I wrote a migration guide. Feedbacks are welcomed! |
garvankeeley
added a commit
to garvankeeley/CombineX
that referenced
this pull request
Mar 11, 2021
garvankeeley
added a commit
to garvankeeley/CombineX
that referenced
this pull request
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new versions of
RunLoopandOperationQueue(copied from the Apple implementations) have incorrect implementations ofSchedulerTimeType::distance(to:).The original Apple implementations rely on
Date::distance(to:), which is only available on the 2019 and later systems. So CombineX replaces the use ofDate::distance(to:)withDate::timeIntervalSince(_:).The problem is that the calls to
timeIntervalSincehavedateandother.datein the wrong places, so each call todistance(to:)returns aStridewith a flipped sign.This pull request contains two commits.
The first commit adds a test case demonstrating the incorrect behavior. The test case succeeds when compiled with Combine and fails when compiled with CombineX. The test case is a little tricky because I was unable to make it compile with Combine using the
RunLoop.CX.SchedulerTimeTypetype. I worked around it with type inference, so that it usesRunLoop.SchedulerTimeTypewhen compiled with Combine andRunLoop.CX.SchedulerTimeTypewhen compiled with CombineX.The second commit fixes the two implementations of
distance(to:).