Add system monitoring and persistent alert management to daemon#685
Add system monitoring and persistent alert management to daemon#685
Conversation
Co-authored-by: mikejmorgan-ai <73376634+mikejmorgan-ai@users.noreply.github.com>
Co-authored-by: mikejmorgan-ai <73376634+mikejmorgan-ai@users.noreply.github.com>
Co-authored-by: mikejmorgan-ai <73376634+mikejmorgan-ai@users.noreply.github.com>
…l issues Co-authored-by: mikejmorgan-ai <73376634+mikejmorgan-ai@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- wezterm → cx-terminal - wezterm-gui → cx-terminal-gui Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add alsa-lib-devel for Fedora/CentOS - Add libasound2-dev for Debian/Ubuntu Required for cx-daemon monitoring features. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required for cx-daemon monitoring features. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
🤖 Fix all issues with AI agents
In @.github/workflows/gen_macos.yml:
- Around line 62-73: The macOS workflow currently uploads the wrong artifact
name and misses required Rust CI checks; update the upload artifact path in
.github/workflows/gen_macos.yml from WezTerm-*.zip to CXTerminal-*.zip to match
the artifact produced by ci/deploy.sh (which creates CXTerminal-macos-*.zip),
and insert explicit pre-test steps for Cargo Check and Rustfmt check (add steps
running cargo check and cargo fmt --check) before the existing Test Suite step
so the workflow includes Cargo Check, Rustfmt, Tests, and Docs as required.
In `@cx-daemon/src/alerts.rs`:
- Around line 1-4: The file alerts.rs is missing the required BSL 1.1 license
header; add the standard Boost Software License 1.1 header comment at the top of
alerts.rs (above the existing module doc comments like the //! Alert database
lines) so the license block appears as the first lines of the file and covers
the whole source file per project guidelines.
In `@cx-daemon/src/ipc.rs`:
- Around line 1-2: The file ipc.rs (module doc comment "//! IPC request handlers
for the daemon") is missing the BSL 1.1 license header; add the standard BSL 1.1
license header block at the top of ipc.rs before any module comments or code so
the file includes the required license text per project guidelines.
In `@cx-daemon/src/lib.rs`:
- Around line 1-3: Update the crate-level doc comments (the top //! comments in
lib.rs) to explain WHY this crate exists (its intent and purpose for the CX
Terminal) rather than WHAT it is; replace or rewrite the current lines to a
purpose-driven sentence that starts with the CX addition marker (use a leading
comment like "// CX Terminal:" immediately before or as part of the crate docs)
and ensure the text follows the project's "why" style (zero documentation
philosophy). Target the crate-level doc comments in lib.rs and keep the original
information concise while emphasizing intent and CX Terminal ownership.
- Around line 1-3: This new Rust file is missing the required BSL 1.1 license
header; add the standard Boost Software License 1.1 header comment block at the
top of cx-daemon/src/lib.rs including the copyright notice "AI Venture Holdings
LLC" and the SPDX or license text per project guidelines so the file begins with
the full BSL 1.1 header before the module doc comments (i.e., above the existing
//! CX Daemon shared library lines).
In `@cx-daemon/src/main.rs`:
- Around line 1-7: Add the required BSL 1.1 license header as a top-of-file
comment block to this new Rust source (before the existing crate-level doc
comments) so the file includes the standard Boost Software License 1.1 text;
insert the full BSL 1.1 header (including copyright/years/holder as appropriate)
at the very top of main.rs so the existing module docs remain unchanged below
it.
In `@cx-daemon/src/monitoring.rs`:
- Around line 68-131: check_and_alert currently creates alerts on every run even
when identical active alerts exist, causing duplicates; fix by querying existing
active alerts before calling create_alert: add a helper like
has_active_alert(&self, source: &str) that locks alert_db and lists alerts
filtered by AlertStatus::Active (use the same DB access pattern as
create_alert), then in check_and_alert (for each alerting branch:
memory_monitor, disk_monitor, service_monitor) call has_active_alert and skip
create_alert if an active alert from the same source already exists; ensure you
reference create_alert, check_and_alert, alert_db/list and AlertStatus::Active
when implementing the check.
- Around line 1-4: Add the BSL 1.1 license header to the top of the new module
file above the existing module docs; specifically insert the standard BSL 1.1
block header at the very beginning of cx-daemon/src/monitoring.rs (i.e., before
the leading "//! System monitoring service" comments) so the file includes the
required license text for new files while preserving the existing module-level
documentation.
In `@cx-daemon/src/paths.rs`:
- Line 1: Add the BSL 1.1 license header to the top of the new file (paths.rs)
including the copyright notice for AI Venture Holdings LLC; update the
module-level comment (the existing //! Shared utilities for CX daemon) so the
license header appears above it and ensure the full BSL 1.1 block is present and
formatted as a Rust comment (//! or /* ... */) per project convention.
In `@wezterm/src/cli/daemon.rs`:
- Line 1: Add the BSL 1.1 license header at the top of the file (above the
existing module doc comment "//! CLI commands for interacting with the CX
daemon"), using the project's standard Boost Software License 1.1 block and
filling in the correct year and copyright owner; ensure the header is formatted
as a comment and placed before any code or module-level doc comments.
- Line 7: The use of std::os::unix::net::UnixStream causes Windows build
failures; update DaemonCommand::run (and any functions referencing UnixStream)
to use conditional compilation: add a #[cfg(not(unix))] branch that returns a
clear error (e.g., bail or Err) stating daemon commands are only supported on
Unix, and wrap the existing Unix-specific logic behind #[cfg(unix)] so
UnixStream is only referenced on Unix targets.
In `@wezterm/src/main.rs`:
- Around line 180-185: Replace the current doc comment for the Daemon enum
variant with a brief WHY-focused comment prefixed by the CX marker: add a Rust
line comment starting with "// CX Terminal:" that explains the intent/purpose of
the Daemon subcommand (e.g., why we expose it: to monitor and manage daemon
health/status/alerts for CX Terminal integration), and update the associated
#[command(..., about = "...")] text if needed to match that intent; locate the
Daemon enum variant (Daemon(cli::daemon::DaemonCommand)) and change the
triple-slash WHAT comment to the CX WHY comment accordingly.
🧹 Nitpick comments (8)
cx-daemon/src/main.rs (2)
207-214: Shutdown viaprocess::exit(0)leaves socket file orphaned.The daemon exits immediately without removing the socket file. While the code handles this on startup (line 146-148), a cleaner approach would be to signal the main loop to exit gracefully.
Consider using a shutdown flag or channel to break the accept loop and perform cleanup, rather than calling
process::exit(0)directly from the client handler thread.
176-177: Unreachable code:monitoring_thread.join()will never execute.The
for stream in listener.incoming()loop runs indefinitely (or until process exit), so this join call is unreachable. If this is intentional (daemon runs forever), consider removing the dead code or adding a comment explaining the intent.wezterm/src/cli/daemon.rs (1)
53-95: Consider reusing IPC types fromcx-daemoncrate.The
RequestandResponseenums here duplicate theDaemonRequestandDaemonResponsetypes defined incx-daemon/src/ipc.rs. While the slight differences in field naming/structure may be intentional (CLI vs daemon perspective), this creates a maintenance burden where protocol changes require updates in two places.Consider either:
- Reusing the types from
cx_daemon::ipcdirectly, or- Creating a shared protocol crate if the types must differ
cx-daemon/src/alerts.rs (3)
32-40: Consider implementingstd::str::FromStrtrait.The custom
from_strmethod works but implementing the standardFromStrtrait would allow using.parse()and integrate better with the Rust ecosystem.
174-188: Silent fallback on invalid data could mask database corruption.When parsing severity, status, or timestamps from the database fails, the code silently falls back to defaults (
AlertSeverity::Info,AlertStatus::Active,Utc::now()). This could hide data integrity issues.Consider logging a warning when fallback occurs:
severity: AlertSeverity::from_str(&row.get::<_, String>(1)?) .unwrap_or_else(|| { log::warn!("Invalid severity in DB, defaulting to Info"); AlertSeverity::Info }),
301-335: Test cleanup could be more robust.The test removes the temp file at the end, but if the test panics earlier, the file remains. Consider using a test helper or
Dropguard for cleanup.cx-daemon/src/monitoring.rs (1)
140-146:Mutex::lock().unwrap()can panic on poisoned lock.If another thread panics while holding the lock, subsequent
unwrap()calls will panic. Consider usinglock().unwrap_or_else(|e| e.into_inner())or proper error handling to maintain daemon stability.cx-daemon/src/ipc.rs (1)
153-170: Consistent mutex handling pattern recommended.Multiple methods use
.lock().unwrap()which can panic on poisoned locks. Consider extracting a helper method or using a consistent error-handling pattern across all handlers.fn with_db<F, T>(&self, f: F) -> Result<T, String> where F: FnOnce(&AlertDatabase) -> Result<T>, { let db = self.alert_db.lock() .map_err(|_| "Database lock poisoned".to_string())?; f(&db).map_err(|e| e.to_string()) }
| - name: "Build cx-terminal (Release mode Intel)" | ||
| shell: bash | ||
| run: "cargo build --target x86_64-apple-darwin -p wezterm --release" | ||
| run: "cargo build --target x86_64-apple-darwin -p cx-terminal --release" | ||
| - name: "Build cx-terminal (Release mode ARM)" | ||
| shell: bash | ||
| run: "cargo build --target aarch64-apple-darwin -p wezterm --release" | ||
| run: "cargo build --target aarch64-apple-darwin -p cx-terminal --release" | ||
| - name: "Build cx-terminal-gui (Release mode Intel)" | ||
| shell: bash | ||
| run: "cargo build --target x86_64-apple-darwin -p wezterm-gui --release" | ||
| run: "cargo build --target x86_64-apple-darwin -p cx-terminal-gui --release" | ||
| - name: "Build cx-terminal-gui (Release mode ARM)" | ||
| shell: bash | ||
| run: "cargo build --target aarch64-apple-darwin -p wezterm-gui --release" | ||
| run: "cargo build --target aarch64-apple-darwin -p cx-terminal-gui --release" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check if macOS bundle structure exists
test -f "assets/macos/CX Terminal.app/Contents/Info.plist" && echo "✓ Info.plist exists" || echo "✗ Info.plist missing"
# Examine ci/deploy.sh for binary references and artifact naming
echo "=== ci/deploy.sh references ===" && cat -n ci/deploy.sh | head -100Repository: cxlinux-ai/cx-core
Length of output: 148
🏁 Script executed:
# Search for any references to cx-terminal or wezterm in deploy scripts
echo "=== Binary references in deploy-related files ===" && \
rg -n "(cx-terminal|cx_terminal|wezterm|WezTerm)" --type bash --type sh . 2>/dev/null | head -30Repository: cxlinux-ai/cx-core
Length of output: 111
🏁 Script executed:
# Direct file existence check
ls -la "assets/macos/CX Terminal.app/Contents/Info.plist" 2>&1 || echo "File not found"Repository: cxlinux-ai/cx-core
Length of output: 159
🏁 Script executed:
# Locate ci/deploy.sh
find . -name "deploy.sh" -o -name "*deploy*" -type f | grep -v node_modules | head -20Repository: cxlinux-ai/cx-core
Length of output: 76
🏁 Script executed:
# Check gen_macos.yml for CI checks (Cargo Check, Rustfmt, Test Suite, Documentation Tests)
grep -n "cargo check\|rustfmt\|test\|cargo test\|doc-tests" .github/workflows/gen_macos.yml || echo "No CI checks found"Repository: cxlinux-ai/cx-core
Length of output: 266
🏁 Script executed:
# Read the gen_macos.yml workflow file
cat -n .github/workflows/gen_macos.ymlRepository: cxlinux-ai/cx-core
Length of output: 4180
🏁 Script executed:
# Read the deploy script to see how it consumes binaries
cat -n ci/deploy.shRepository: cxlinux-ai/cx-core
Length of output: 20928
Fix artifact upload path and add required CI checks to macOS workflow.
The ci/deploy.sh script produces CXTerminal-macos-*.zip, not WezTerm-*.zip. Line 101 of the workflow uploads with path WezTerm-*.zip, which won't match the actual artifact produced by deploy.sh on line 96, causing upload failures.
Additionally, the workflow is missing required CI checks. Per coding guidelines for .github/workflows/**/*.{yml,yaml}, all Rust PRs must include: Cargo Check, Rustfmt, Test Suite (present), and Documentation Tests. Add explicit cargo check and cargo fmt --check steps before the test suite.
Artifact path mismatch
Line 96 runs ci/deploy.sh, which creates CXTerminal-macos-$TAG_NAME.zip (per lines 25–31 in ci/deploy.sh).
Line 101 attempts to upload WezTerm-*.zip, which doesn't exist.
Update line 101 to: path: "CXTerminal-*.zip"
🤖 Prompt for AI Agents
In @.github/workflows/gen_macos.yml around lines 62 - 73, The macOS workflow
currently uploads the wrong artifact name and misses required Rust CI checks;
update the upload artifact path in .github/workflows/gen_macos.yml from
WezTerm-*.zip to CXTerminal-*.zip to match the artifact produced by ci/deploy.sh
(which creates CXTerminal-macos-*.zip), and insert explicit pre-test steps for
Cargo Check and Rustfmt check (add steps running cargo check and cargo fmt
--check) before the existing Test Suite step so the workflow includes Cargo
Check, Rustfmt, Tests, and Docs as required.
| //! Alert database for persistent alert storage | ||
| //! | ||
| //! Stores alerts in SQLite database at ~/.cx/alerts.db | ||
|
|
There was a problem hiding this comment.
Missing BSL 1.1 license header.
New files require the BSL 1.1 license header. As per coding guidelines.
🤖 Prompt for AI Agents
In `@cx-daemon/src/alerts.rs` around lines 1 - 4, The file alerts.rs is missing
the required BSL 1.1 license header; add the standard Boost Software License 1.1
header comment at the top of alerts.rs (above the existing module doc comments
like the //! Alert database lines) so the license block appears as the first
lines of the file and covers the whole source file per project guidelines.
| //! IPC request handlers for the daemon | ||
|
|
There was a problem hiding this comment.
Missing BSL 1.1 license header.
New files require the BSL 1.1 license header. As per coding guidelines.
🤖 Prompt for AI Agents
In `@cx-daemon/src/ipc.rs` around lines 1 - 2, The file ipc.rs (module doc comment
"//! IPC request handlers for the daemon") is missing the BSL 1.1 license
header; add the standard BSL 1.1 license header block at the top of ipc.rs
before any module comments or code so the file includes the required license
text per project guidelines.
| //! CX Daemon shared library | ||
| //! | ||
| //! Provides shared utilities for the daemon and CLI |
There was a problem hiding this comment.
Rephrase crate docs to state intent and include the CX Terminal prefix.
The current doc comments describe what the module is, but the guideline asks for why plus the CX Terminal prefix.
✍️ Suggested rewrite
-//! CX Daemon shared library
-//!
-//! Provides shared utilities for the daemon and CLI
+//! CX Terminal: Keep daemon/CLI path resolution consistent to avoid diverging socket and DB locations.🤖 Prompt for AI Agents
In `@cx-daemon/src/lib.rs` around lines 1 - 3, Update the crate-level doc comments
(the top //! comments in lib.rs) to explain WHY this crate exists (its intent
and purpose for the CX Terminal) rather than WHAT it is; replace or rewrite the
current lines to a purpose-driven sentence that starts with the CX addition
marker (use a leading comment like "// CX Terminal:" immediately before or as
part of the crate docs) and ensure the text follows the project's "why" style
(zero documentation philosophy). Target the crate-level doc comments in lib.rs
and keep the original information concise while emphasizing intent and CX
Terminal ownership.
Add BSL 1.1 license header to this new Rust file.
This file is new and currently lacks the required license header.
📝 Suggested header
+// Copyright (c) 2026 AI Venture Holdings LLC
+// SPDX-License-Identifier: BSL-1.1
+
//! CX Daemon shared library
//!
//! Provides shared utilities for the daemon and CLI📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| //! CX Daemon shared library | |
| //! | |
| //! Provides shared utilities for the daemon and CLI | |
| // Copyright (c) 2026 AI Venture Holdings LLC | |
| // SPDX-License-Identifier: BSL-1.1 | |
| //! CX Daemon shared library | |
| //! | |
| //! Provides shared utilities for the daemon and CLI |
🤖 Prompt for AI Agents
In `@cx-daemon/src/lib.rs` around lines 1 - 3, This new Rust file is missing the
required BSL 1.1 license header; add the standard Boost Software License 1.1
header comment block at the top of cx-daemon/src/lib.rs including the copyright
notice "AI Venture Holdings LLC" and the SPDX or license text per project
guidelines so the file begins with the full BSL 1.1 header before the module doc
comments (i.e., above the existing //! CX Daemon shared library lines).
| //! CX Daemon - System monitoring and alert management daemon for CX Linux | ||
| //! | ||
| //! The daemon provides: | ||
| //! - System health monitoring (memory, disk, services) | ||
| //! - Persistent alert management with SQLite storage | ||
| //! - IPC interface via Unix socket for terminal integration | ||
|
|
There was a problem hiding this comment.
Missing BSL 1.1 license header.
New files require the BSL 1.1 license header. As per coding guidelines.
📜 Suggested license header
+// Copyright (c) 2026 AI Venture Holdings LLC
+//
+// This file is part of CX Linux and is licensed under the Business Source License 1.1.
+// See the LICENSE file in the project root for license information.
+
//! CX Daemon - System monitoring and alert management daemon for CX Linux📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| //! CX Daemon - System monitoring and alert management daemon for CX Linux | |
| //! | |
| //! The daemon provides: | |
| //! - System health monitoring (memory, disk, services) | |
| //! - Persistent alert management with SQLite storage | |
| //! - IPC interface via Unix socket for terminal integration | |
| // Copyright (c) 2026 AI Venture Holdings LLC | |
| // | |
| // This file is part of CX Linux and is licensed under the Business Source License 1.1. | |
| // See the LICENSE file in the project root for license information. | |
| //! CX Daemon - System monitoring and alert management daemon for CX Linux | |
| //! | |
| //! The daemon provides: | |
| //! - System health monitoring (memory, disk, services) | |
| //! - Persistent alert management with SQLite storage | |
| //! - IPC interface via Unix socket for terminal integration | |
🤖 Prompt for AI Agents
In `@cx-daemon/src/main.rs` around lines 1 - 7, Add the required BSL 1.1 license
header as a top-of-file comment block to this new Rust source (before the
existing crate-level doc comments) so the file includes the standard Boost
Software License 1.1 text; insert the full BSL 1.1 header (including
copyright/years/holder as appropriate) at the very top of main.rs so the
existing module docs remain unchanged below it.
| pub fn check_and_alert(&self) -> Result<()> { | ||
| let health = self.get_health()?; | ||
|
|
||
| // Check memory usage | ||
| if health.memory_usage_percent >= self.config.memory_critical_threshold { | ||
| self.create_alert( | ||
| AlertSeverity::Critical, | ||
| "memory_monitor", | ||
| "Critical Memory Usage", | ||
| &format!( | ||
| "Memory usage is at {:.1}% (critical threshold: {:.1}%)", | ||
| health.memory_usage_percent, self.config.memory_critical_threshold | ||
| ), | ||
| )?; | ||
| } else if health.memory_usage_percent >= self.config.memory_warning_threshold { | ||
| self.create_alert( | ||
| AlertSeverity::Warning, | ||
| "memory_monitor", | ||
| "High Memory Usage", | ||
| &format!( | ||
| "Memory usage is at {:.1}% (warning threshold: {:.1}%)", | ||
| health.memory_usage_percent, self.config.memory_warning_threshold | ||
| ), | ||
| )?; | ||
| } | ||
|
|
||
| // Check disk usage | ||
| if health.disk_usage_percent >= self.config.disk_critical_threshold { | ||
| self.create_alert( | ||
| AlertSeverity::Critical, | ||
| "disk_monitor", | ||
| "Critical Disk Space", | ||
| &format!( | ||
| "Disk usage is at {:.1}% (critical threshold: {:.1}%)", | ||
| health.disk_usage_percent, self.config.disk_critical_threshold | ||
| ), | ||
| )?; | ||
| } else if health.disk_usage_percent >= self.config.disk_warning_threshold { | ||
| self.create_alert( | ||
| AlertSeverity::Warning, | ||
| "disk_monitor", | ||
| "Low Disk Space", | ||
| &format!( | ||
| "Disk usage is at {:.1}% (warning threshold: {:.1}%)", | ||
| health.disk_usage_percent, self.config.disk_warning_threshold | ||
| ), | ||
| )?; | ||
| } | ||
|
|
||
| // Check for failed services | ||
| if !health.failed_services.is_empty() { | ||
| self.create_alert( | ||
| AlertSeverity::Error, | ||
| "service_monitor", | ||
| "Failed Services Detected", | ||
| &format!( | ||
| "The following services have failed: {}", | ||
| health.failed_services.join(", ") | ||
| ), | ||
| )?; | ||
| } | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Potential alert flooding: duplicate alerts created on each check interval.
The check_and_alert method creates a new alert every time a threshold is exceeded, even if an identical active alert already exists. With a 5-minute default interval, this could rapidly fill the database with duplicate alerts during sustained high-resource conditions.
Consider checking for existing active alerts from the same source before creating new ones:
// Before creating a new alert, check if a similar active alert exists
fn has_active_alert(&self, source: &str) -> Result<bool> {
let db = self.alert_db.lock().unwrap();
let alerts = db.list(Some(AlertStatus::Active), None)?;
Ok(alerts.iter().any(|a| a.source == source))
}🤖 Prompt for AI Agents
In `@cx-daemon/src/monitoring.rs` around lines 68 - 131, check_and_alert currently
creates alerts on every run even when identical active alerts exist, causing
duplicates; fix by querying existing active alerts before calling create_alert:
add a helper like has_active_alert(&self, source: &str) that locks alert_db and
lists alerts filtered by AlertStatus::Active (use the same DB access pattern as
create_alert), then in check_and_alert (for each alerting branch:
memory_monitor, disk_monitor, service_monitor) call has_active_alert and skip
create_alert if an active alert from the same source already exists; ensure you
reference create_alert, check_and_alert, alert_db/list and AlertStatus::Active
when implementing the check.
| @@ -0,0 +1,32 @@ | |||
| //! Shared utilities for CX daemon | |||
There was a problem hiding this comment.
Missing BSL 1.1 license header.
New files require the BSL 1.1 license header with copyright to AI Venture Holdings LLC. As per coding guidelines: "Include BSL 1.1 license header on all new files with copyright to AI Venture Holdings LLC".
📜 Suggested license header
+// Copyright (c) 2026 AI Venture Holdings LLC
+//
+// This file is part of CX Linux and is licensed under the Business Source License 1.1.
+// See the LICENSE file in the project root for license information.
+
//! Shared utilities for CX daemon📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| //! Shared utilities for CX daemon | |
| // Copyright (c) 2026 AI Venture Holdings LLC | |
| // | |
| // This file is part of CX Linux and is licensed under the Business Source License 1.1. | |
| // See the LICENSE file in the project root for license information. | |
| //! Shared utilities for CX daemon |
🤖 Prompt for AI Agents
In `@cx-daemon/src/paths.rs` at line 1, Add the BSL 1.1 license header to the top
of the new file (paths.rs) including the copyright notice for AI Venture
Holdings LLC; update the module-level comment (the existing //! Shared utilities
for CX daemon) so the license header appears above it and ensure the full BSL
1.1 block is present and formatted as a Rust comment (//! or /* ... */) per
project convention.
| @@ -0,0 +1,335 @@ | |||
| //! CLI commands for interacting with the CX daemon | |||
There was a problem hiding this comment.
Missing BSL 1.1 license header.
New files require the BSL 1.1 license header. As per coding guidelines.
🤖 Prompt for AI Agents
In `@wezterm/src/cli/daemon.rs` at line 1, Add the BSL 1.1 license header at the
top of the file (above the existing module doc comment "//! CLI commands for
interacting with the CX daemon"), using the project's standard Boost Software
License 1.1 block and filling in the correct year and copyright owner; ensure
the header is formatted as a comment and placed before any code or module-level
doc comments.
| use clap::Parser; | ||
| use serde::{Deserialize, Serialize}; | ||
| use std::io::{BufRead, BufReader, Write}; | ||
| use std::os::unix::net::UnixStream; |
There was a problem hiding this comment.
Build failure on Windows: std::os::unix is not available.
The pipeline failure indicates this code doesn't compile on Windows because std::os::unix::net::UnixStream is Unix-only. Consider adding platform-specific compilation or a graceful error message.
🔧 Proposed fix with conditional compilation
//! CLI commands for interacting with the CX daemon
use anyhow::{Context, Result};
use clap::Parser;
use serde::{Deserialize, Serialize};
-use std::io::{BufRead, BufReader, Write};
-use std::os::unix::net::UnixStream;
use std::path::PathBuf;
+
+#[cfg(unix)]
+use std::io::{BufRead, BufReader, Write};
+#[cfg(unix)]
+use std::os::unix::net::UnixStream;Then guard the implementation:
impl DaemonCommand {
pub fn run(&self) -> Result<()> {
#[cfg(not(unix))]
{
anyhow::bail!("Daemon commands are only supported on Unix systems");
}
#[cfg(unix)]
{
// existing implementation
}
}
}🧰 Tools
🪛 GitHub Actions: windows
[error] 7-7: could not find unix in os. use std::os::unix::net::UnixStream;
🤖 Prompt for AI Agents
In `@wezterm/src/cli/daemon.rs` at line 7, The use of
std::os::unix::net::UnixStream causes Windows build failures; update
DaemonCommand::run (and any functions referencing UnixStream) to use conditional
compilation: add a #[cfg(not(unix))] branch that returns a clear error (e.g.,
bail or Err) stating daemon commands are only supported on Unix, and wrap the
existing Unix-specific logic behind #[cfg(unix)] so UnixStream is only
referenced on Unix targets.
| /// Manage the CX daemon | ||
| #[command( | ||
| name = "daemon", | ||
| about = "Manage the CX daemon (status, health, alerts)" | ||
| )] | ||
| Daemon(cli::daemon::DaemonCommand), |
There was a problem hiding this comment.
Adjust daemon subcommand doc comment to reflect intent and use CX prefix.
Line 180’s doc comment is a what description; the guideline prefers why and the CX Terminal prefix.
✍️ Suggested rewrite
- /// Manage the CX daemon
+ /// CX Terminal: Surface daemon health/alerts for troubleshooting from the CLI.🤖 Prompt for AI Agents
In `@wezterm/src/main.rs` around lines 180 - 185, Replace the current doc comment
for the Daemon enum variant with a brief WHY-focused comment prefixed by the CX
marker: add a Rust line comment starting with "// CX Terminal:" that explains
the intent/purpose of the Daemon subcommand (e.g., why we expose it: to monitor
and manage daemon health/status/alerts for CX Terminal integration), and update
the associated #[command(..., about = "...")] text if needed to match that
intent; locate the Daemon enum variant (Daemon(cli::daemon::DaemonCommand)) and
change the triple-slash WHAT comment to the CX WHY comment accordingly.
The daemon lacked ability to monitor system health and manage alerts persistently. This adds monitoring for memory, disk space, and failed systemd services with SQLite-backed alert storage.
Implementation
New
cx-daemonbinary/proc/meminfo), disk (statvfs), and systemd services$XDG_RUNTIME_DIR/cx/daemon.sockor~/.cx/daemon.sockAlert database (
alerts.rs)~/.cx/alerts.dbactive→acknowledged→dismissedIPC handlers (
ipc.rs)Health,Status,Alerts,AcknowledgeAlert,DismissAlert,AcknowledgeAllAlertsCLI commands
Shared path module (
paths.rs)Example
Security
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Summary by CodeRabbit
Release Notes
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.